Netdev List
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org, herbert@gondor.apana.org.au
Subject: Re: [PATCH net-next] tcp: md5: remove spinlock usage in fast path
Date: Mon, 20 May 2013 14:01:18 -0700 (PDT)	[thread overview]
Message-ID: <20130520.140118.176987219677786436.davem@davemloft.net> (raw)
In-Reply-To: <1369068746.3301.194.camel@edumazet-glaptop>

From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Mon, 20 May 2013 09:52:26 -0700

> From: Eric Dumazet <edumazet@google.com>
> 
> TCP md5 code uses per cpu variables but protects access to them with
> a shared spinlock, which is a contention point.
> 
> [ tcp_md5sig_pool_lock is locked twice per incoming packet ]
> 
> Makes things much simpler, by allocating crypto structures once, first
> time a socket needs md5 keys, and not deallocating them as they are
> really small.
> 
> Next step would be to allow crypto allocations being done in a NUMA
> aware way.
> 
> Signed-off-by: Eric Dumazet <edumazet@google.com>

Looks good, applied, thanks Eric.

      reply	other threads:[~2013-05-20 21:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-20 16:52 [PATCH net-next] tcp: md5: remove spinlock usage in fast path Eric Dumazet
2013-05-20 21:01 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130520.140118.176987219677786436.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox