From: Wei Yang <weiyang@linux.vnet.ibm.com>
To: jeffrey.t.kirsher@intel.com
Cc: e1000-devel@lists.sourceforge.net, netdev@vger.kernel.org
Subject: Re: [PATCH 3/4] e1000e: Calculate the desc_len based on adapter type
Date: Tue, 21 May 2013 00:25:29 +0800 [thread overview]
Message-ID: <20130520162529.GC18520@weiyang.vnet.ibm.com> (raw)
In-Reply-To: <5199EEEC.5030105@gmail.com>
On Mon, May 20, 2013 at 02:37:48AM -0700, Jeff Kirsher wrote:
>On 05/20/2013 01:15 AM, Wei Yang wrote:
>> desc_len represents the size of descriptor in rx_ring. There are two kinds of
>> rx descriptors, e1000_rx_desc_packet_split(32 byte) and
>> e1000_rx_desc_extended(16 byte). Different adapter will use different rx
>> descriptors.
>>
>> When allocating the dma space for this descriptor in current implementation,
>> the code ignore the descriptor type and take it as e1000_rx_desc_packet_split
>> in any case. This behavior will not effect the function, but will require
>> double size of dma space.
>>
>> This patch will calculate the desc_len based on the adapter type.
>>
>> Tested on T420, which use e1000_rx_desc_extended and works fine.
>>
>> Signed-off-by: Wei Yang <weiyang@linux.vnet.ibm.com>
>> ---
>> drivers/net/ethernet/intel/e1000e/netdev.c | 7 ++++++-
>> 1 files changed, 6 insertions(+), 1 deletions(-)
>Thanks, I have added the patch to my queue for e1000e.
>
Thanks~
--
Richard Yang
Help you, Help me
next prev parent reply other threads:[~2013-05-20 16:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-20 8:15 [PATCH 0/4] trivial clean up for e1000e driver Wei Yang
2013-05-20 8:15 ` [PATCH 1/4] e1000e: Remove duplicate assignment of default rx/tx ring size Wei Yang
2013-05-20 9:37 ` Jeff Kirsher
2013-05-20 16:24 ` Wei Yang
2013-05-20 8:15 ` [PATCH 2/4] e1000e: Use marco instead of digit for defining e1000_rx_desc_packet_split Wei Yang
2013-05-20 9:37 ` Jeff Kirsher
2013-05-20 16:24 ` Wei Yang
2013-05-20 8:15 ` [PATCH 3/4] e1000e: Calculate the desc_len based on adapter type Wei Yang
2013-05-20 9:37 ` Jeff Kirsher
2013-05-20 16:25 ` Wei Yang [this message]
2013-08-22 10:57 ` Jeff Kirsher
2013-08-22 14:26 ` Wei Yang
2013-05-20 8:15 ` [PATCH 4/4] e1000e: Not initialize the e1000_ps_page array when packet-split is not used Wei Yang
2013-05-20 9:38 ` Jeff Kirsher
2013-05-20 16:25 ` Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130520162529.GC18520@weiyang.vnet.ibm.com \
--to=weiyang@linux.vnet.ibm.com \
--cc=e1000-devel@lists.sourceforge.net \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).