* [PATCH] net/ethernet/micrel/ks8851.c: Use module_spi_driver to register driver
@ 2013-05-20 19:56 Peter Huewe
2013-05-20 20:09 ` Peter Hüwe
0 siblings, 1 reply; 2+ messages in thread
From: Peter Huewe @ 2013-05-20 19:56 UTC (permalink / raw)
To: David S. Miller
Cc: Bill Pemberton, Peter Huewe, Greg Kroah-Hartman, Jiri Pirko,
netdev, linux-kernel
Removing some boilerplate by using module_spi_driver instead of calling
register and unregister in the otherwise empty init/exit functions
Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
---
drivers/net/ethernet/micrel/ks8851.c | 14 +-------------
1 file changed, 1 insertion(+), 13 deletions(-)
diff --git a/drivers/net/ethernet/micrel/ks8851.c b/drivers/net/ethernet/micrel/ks8851.c
index 33bcb63..ca91e7c 100644
--- a/drivers/net/ethernet/micrel/ks8851.c
+++ b/drivers/net/ethernet/micrel/ks8851.c
@@ -1539,19 +1539,7 @@ static struct spi_driver ks8851_driver = {
.resume = ks8851_resume,
};
-static int __init ks8851_init(void)
-{
- return spi_register_driver(&ks8851_driver);
-}
-
-static void __exit ks8851_exit(void)
-{
- spi_unregister_driver(&ks8851_driver);
-}
-
-module_init(ks8851_init);
-module_exit(ks8851_exit);
-
+module_spi_driver(ks8851_driver);
MODULE_DESCRIPTION("KS8851 Network driver");
MODULE_AUTHOR("Ben Dooks <ben@simtec.co.uk>");
MODULE_LICENSE("GPL");
--
1.8.1.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net/ethernet/micrel/ks8851.c: Use module_spi_driver to register driver
2013-05-20 19:56 [PATCH] net/ethernet/micrel/ks8851.c: Use module_spi_driver to register driver Peter Huewe
@ 2013-05-20 20:09 ` Peter Hüwe
0 siblings, 0 replies; 2+ messages in thread
From: Peter Hüwe @ 2013-05-20 20:09 UTC (permalink / raw)
To: David S. Miller
Cc: Bill Pemberton, Greg Kroah-Hartman, Jiri Pirko, netdev,
linux-kernel
Am Montag, 20. Mai 2013, 21:56:16 schrieb Peter Huewe:
> Removing some boilerplate by using module_spi_driver instead of calling
> register and unregister in the otherwise empty init/exit functions
>
> Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
Sorry for the noise
already exists in 3.10-rc1 by Lars-Peter Clausen
0582ce92 net: ks8851: Use module_spi_driver Lars-Peter Clausen
I was working on an stale tree - sorry.
Please ignore this patch.
Peter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-05-20 20:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-20 19:56 [PATCH] net/ethernet/micrel/ks8851.c: Use module_spi_driver to register driver Peter Huewe
2013-05-20 20:09 ` Peter Hüwe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).