From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: David Vrabel <david.vrabel@citrix.com>,
xen-devel@lists.xen.org, netdev@vger.kernel.org,
ian.campbell@citrix.com
Subject: Re: [Xen-devel] [PATCH net-next 2/2] xen-netfront: split event channels feature support
Date: Tue, 21 May 2013 12:28:25 -0400 [thread overview]
Message-ID: <20130521162825.GA3669@phenom.dumpdata.com> (raw)
In-Reply-To: <20130521134149.GN32007@zion.uk.xensource.com>
On Tue, May 21, 2013 at 02:41:49PM +0100, Wei Liu wrote:
> On Tue, May 21, 2013 at 02:39:01PM +0100, David Vrabel wrote:
> [...]
> > > + info->rx_evtchn = info->tx_evtchn;
> > > + info->rx_irq = info->tx_irq = err;
> > > + dev_info(&info->xbdev->dev,
> > > + "single event channel, evtchn = %d, irq = %d\n",
> > > + info->tx_evtchn, info->tx_irq);
> >
> > This message is pointless chatter as the information is available
> > elsewhere. Please remove.
> >
>
> Do you mean /proc/interrupt by "elsewhere"? Information there doesn't
> give you irq<->evtchn mapping info.
If you really want to, that should be implemented via an DebugFS entry that can
be driven from drivers/xen/events.c. As the events.c is the generic code that sets
up the Xen events, pirqs, ipis, <-> Linux IRQs.
next prev parent reply other threads:[~2013-05-21 16:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-20 23:02 [PATCH net-next 0/2] Xen network: split event channels support Wei Liu
2013-05-20 23:02 ` [PATCH net-next 1/2] xen-netback: split event channels feature support Wei Liu
2013-05-21 13:34 ` [Xen-devel] " David Vrabel
2013-05-21 14:33 ` Wei Liu
2013-05-20 23:02 ` [PATCH net-next 2/2] xen-netfront: " Wei Liu
2013-05-21 13:39 ` [Xen-devel] " David Vrabel
2013-05-21 13:41 ` Wei Liu
2013-05-21 16:28 ` Konrad Rzeszutek Wilk [this message]
2013-05-21 17:07 ` Wei Liu
2013-05-22 15:52 ` David Vrabel
2013-05-21 6:27 ` [PATCH net-next 0/2] Xen network: split event channels support David Miller
2013-05-21 8:00 ` Wei Liu
2013-05-21 8:13 ` David Miller
2013-05-21 8:17 ` Ian Campbell
2013-05-21 8:34 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130521162825.GA3669@phenom.dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=ian.campbell@citrix.com \
--cc=netdev@vger.kernel.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).