netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Flavio Leitner <fbl@redhat.com>
To: netdev@vger.kernel.org
Cc: David Miller <davem@davemloft.net>,
	Eric Dumazet <eric.dumazet@gmail.com>
Subject: RFC limit sk_mem_quantum to 8192
Date: Tue, 21 May 2013 21:45:41 -0300	[thread overview]
Message-ID: <20130522004541.GA17240@obelix.rh> (raw)


Hi,

The page size can be 64k on ppc64, so SK_MEM_QUANTUM increases to
that value as well.

net/ipv4/tcp.c:
...
        sysctl_tcp_wmem[0] = SK_MEM_QUANTUM;
        sysctl_tcp_wmem[1] = 16*1024;
        sysctl_tcp_wmem[2] = max(64*1024, max_share);

        sysctl_tcp_rmem[0] = SK_MEM_QUANTUM;
        sysctl_tcp_rmem[1] = 87380;
        sysctl_tcp_rmem[2] = max(87380, max_share);

and:
include/net/sock.h:
#define SK_MEM_QUANTUM ((int)PAGE_SIZE)

ppc64 config:
# CONFIG_PPC_4K_PAGES is not set
# CONFIG_PPC_16K_PAGES is not set
CONFIG_PPC_64K_PAGES=y
# CONFIG_PPC_256K_PAGES is not set

It seems too much for a minimum reserved memory. Also, the
other values are meaningless in this case because default
is only 16k and the maximum is limited to 64k.

This will require a modification in the
Documentation/networking/ip-sysctl.txt as well which states
that default minimum is 1 page.

Also, sk_mem_schedule() and friends will have to consider
that SK_MEM_QUANTUM might not be PAGE_SIZE anymore.

Well, the patch below illustrates what I am talking.
thanks,
fbl

diff --git a/include/net/sock.h b/include/net/sock.h
index 5d84de4..d52fa2d 100644
--- a/include/net/sock.h
+++ b/include/net/sock.h
@@ -954,7 +954,12 @@ static inline struct inode *SOCK_INODE(struct socket *socket)
 extern int __sk_mem_schedule(struct sock *sk, int size, int kind);
 extern void __sk_mem_reclaim(struct sock *sk);
 
+#if PAGE_SIZE < 8192
 #define SK_MEM_QUANTUM ((int)PAGE_SIZE)
+#else
+#define SK_MEM_QUANTUM ((int)8192)
+#endif
+
 #define SK_MEM_QUANTUM_SHIFT ilog2(SK_MEM_QUANTUM)
 #define SK_MEM_SEND	0
 #define SK_MEM_RECV	1

             reply	other threads:[~2013-05-22  0:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-22  0:45 Flavio Leitner [this message]
2013-05-22  1:09 ` RFC limit sk_mem_quantum to 8192 Eric Dumazet
2013-05-22  1:58   ` Flavio Leitner
2013-05-22  2:21     ` Eric Dumazet
2013-05-22 14:31       ` Flavio Leitner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130522004541.GA17240@obelix.rh \
    --to=fbl@redhat.com \
    --cc=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).