From: Flavio Leitner <fbl@redhat.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: netdev@vger.kernel.org, David Miller <davem@davemloft.net>
Subject: Re: RFC limit sk_mem_quantum to 8192
Date: Wed, 22 May 2013 11:31:00 -0300 [thread overview]
Message-ID: <20130522143100.GE17292@obelix.rh> (raw)
In-Reply-To: <1369189261.3301.269.camel@edumazet-glaptop>
On Tue, May 21, 2013 at 07:21:01PM -0700, Eric Dumazet wrote:
> On Tue, 2013-05-21 at 22:58 -0300, Flavio Leitner wrote:
> > On Tue, May 21, 2013 at 06:09:22PM -0700, Eric Dumazet wrote:
> >
> > > Are you sure a network driver doesn't provide skb using a full page ?
> >
> > You lost me. You're saying that today we consider a page size
> > a minimum and so if we reduce that, the skb wouldn't fit in the
> > min sk memory?
>
> SK_MEM_QUANTUM is also used in UDP stack, thats why I am asking.
Yeah, it is. SCTP too, but for the protocol cases, the most
complex one appears to be TCP, and it doesn't seem to be a problem
to replace the minimum with something not page sized.
For the drivers, it seems to have an indirect assumption that
page size bytes is a minimum acceptable, so changing this minimum
could cause a performance issue.
Well, this define is quite old, so I am not sure if there are
other historical reasons to keep it page size. However, if the
idea of fixing SK_MEM_QUANTUM to 4k seems reasonable, I am
willing to spend more time digging into this.
Thanks!
--
fbl
prev parent reply other threads:[~2013-05-22 14:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-22 0:45 RFC limit sk_mem_quantum to 8192 Flavio Leitner
2013-05-22 1:09 ` Eric Dumazet
2013-05-22 1:58 ` Flavio Leitner
2013-05-22 2:21 ` Eric Dumazet
2013-05-22 14:31 ` Flavio Leitner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130522143100.GE17292@obelix.rh \
--to=fbl@redhat.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).