From: David Miller <davem@davemloft.net>
To: emilio@elopez.com.ar
Cc: sfr@canb.auug.org.au, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] net: ethernet: sun: drop unused variable
Date: Thu, 23 May 2013 12:13:29 -0700 (PDT) [thread overview]
Message-ID: <20130523.121329.781995429475451805.davem@davemloft.net> (raw)
In-Reply-To: <519E117F.9040707@elopez.com.ar>
From: Emilio López <emilio@elopez.com.ar>
Date: Thu, 23 May 2013 09:54:23 -0300
> Hi David,
>
> El 23/05/13 03:43, David Miller escribió:
>> From: Emilio López <emilio@elopez.com.ar>
>> Date: Wed, 22 May 2013 20:57:37 -0300
>>
>>> Commit bfd428d ("net: ethernet: sun: initialize variables directly")
>>> dropped the only loop that was using i but did not remove the actual
>>> variable, therefore causing a warning when building. This patch drops
>>> the now redundant line.
>>>
>>> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
>>> Signed-off-by: Emilio López <emilio@elopez.com.ar>
>>
>> Applied.
>
> I see that you applied the series in net instead of net-next; the
> previous patches were in net-next only. This will cause build breakage
> in net because the loop is still there.
My bad, I'll fix this up.
next prev parent reply other threads:[~2013-05-23 19:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-22 5:55 linux-next: build warning after merge of the final tree (net-next tree related) Stephen Rothwell
2013-05-22 13:24 ` Emilio López
2013-05-22 19:26 ` David Miller
2013-05-22 23:57 ` [PATCH 1/3] net: ethernet: apple: drop unused variable Emilio López
2013-05-22 23:57 ` [PATCH 2/3] net: ethernet: korina: " Emilio López
2013-05-23 6:43 ` David Miller
2013-05-22 23:57 ` [PATCH 3/3] net: ethernet: sun: " Emilio López
2013-05-23 6:43 ` David Miller
2013-05-23 12:54 ` Emilio López
2013-05-23 19:13 ` David Miller [this message]
2013-05-23 6:43 ` [PATCH 1/3] net: ethernet: apple: " David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130523.121329.781995429475451805.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=emilio@elopez.com.ar \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).