From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org, therbert@google.com, ycheng@google.com,
ncardwell@google.com
Subject: Re: [PATCH] tcp: xps: fix reordering issues
Date: Thu, 23 May 2013 18:29:39 -0700 (PDT) [thread overview]
Message-ID: <20130523.182939.1656578741039330554.davem@davemloft.net> (raw)
In-Reply-To: <1369331060.3301.396.camel@edumazet-glaptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Thu, 23 May 2013 10:44:20 -0700
> From: Eric Dumazet <edumazet@google.com>
>
> commit 3853b5841c01a ("xps: Improvements in TX queue selection")
> introduced ooo_okay flag, but the condition to set it is slightly wrong.
>
> In our traces, we have seen ACK packets being received out of order,
> and RST packets sent in response.
>
> We should test if we have any packets still in host queue.
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Applied, thanks Eric.
prev parent reply other threads:[~2013-05-24 1:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-23 17:44 [PATCH] tcp: xps: fix reordering issues Eric Dumazet
2013-05-24 1:29 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130523.182939.1656578741039330554.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=therbert@google.com \
--cc=ycheng@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox