netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: lorenzo@google.com
Cc: netdev@vger.kernel.org, edumazet@google.com,
	yoshfuji@linux-ipv6.org, segoon@openwall.com
Subject: Re: [PATCH] net: ipv6: Add IPv6 support to the ping socket.
Date: Sat, 25 May 2013 21:11:16 -0700 (PDT)	[thread overview]
Message-ID: <20130525.211116.1055819647914301942.davem@davemloft.net> (raw)
In-Reply-To: <1369289851-25570-2-git-send-email-lorenzo@google.com>

From: Lorenzo Colitti <lorenzo@google.com>
Date: Thu, 23 May 2013 15:17:31 +0900

> This adds the ability to send ICMPv6 echo requests without a
> raw socket. The equivalent ability for ICMPv4 was added in
> 2011.
> 
> Instead of having separate code paths for IPv4 and IPv6, make
> most of the code in net/ipv4/ping.c dual-stack and only add a
> few IPv6-specific bits (like the protocol definition) to a new
> net/ipv6/ping.c. Hopefully this will reduce divergence and/or
> duplication of bugs in the future.
> 
> Caveats:
> 
> - Setting options via ancillary data (e.g., using IPV6_PKTINFO
>   to specify the outgoing interface) is not yet supported.
> - There are no separate security settings for IPv4 and IPv6;
>   everything is controlled by /proc/net/ipv4/ping_group_range.
> - The proc interface does not yet display IPv6 ping sockets
>   properly.
> 
> Tested with a patched copy of ping6 and using raw socket calls.
> Compiles and works with all of CONFIG_IPV6={n,m,y}.
> 
> Signed-off-by: Lorenzo Colitti <lorenzo@google.com>

Ok, looks pretty good, applied.

  reply	other threads:[~2013-05-26  4:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-23  6:17 [PATCH] net: ipv6: Add IPv6 support to the ping socket Lorenzo Colitti
2013-05-26  4:11 ` David Miller [this message]
  -- strict thread matches above, loose matches on Subject: below --
2013-05-14 14:58 Lorenzo Colitti
2013-05-14 15:16 ` Eric Dumazet
     [not found]   ` <CAKD1Yr0s1pD-BwXcanf-zzHxUUtze6X_dKgL+eyLH0HD46zwHg@mail.gmail.com>
2013-05-14 15:30     ` Eric Dumazet
2013-05-15  0:47 ` Cong Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130525.211116.1055819647914301942.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=lorenzo@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=segoon@openwall.com \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).