* [PATCH] ptp_pch: depends on PCI
@ 2013-05-25 16:55 Kyle McMartin
2013-05-26 6:11 ` David Miller
0 siblings, 1 reply; 4+ messages in thread
From: Kyle McMartin @ 2013-05-25 16:55 UTC (permalink / raw)
To: netdev; +Cc: richardcochran
It's only accessible via PCI, but has no dependencies, so it ends up
being selected on s390 where a bunch of primitives only exist if
CONFIG_PCI=y (such as {request,free}_irq)
Signed-off-by: Kyle McMartin <kyle@redhat.com>
--- a/drivers/ptp/Kconfig
+++ b/drivers/ptp/Kconfig
@@ -72,6 +72,7 @@ config DP83640_PHY
config PTP_1588_CLOCK_PCH
tristate "Intel PCH EG20T as PTP clock"
+ depends on PCI
select PTP_1588_CLOCK
help
This driver adds support for using the PCH EG20T as a PTP
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] ptp_pch: depends on PCI
2013-05-25 16:55 [PATCH] ptp_pch: depends on PCI Kyle McMartin
@ 2013-05-26 6:11 ` David Miller
2013-05-26 16:20 ` Kyle McMartin
2013-05-27 14:33 ` Ben Hutchings
0 siblings, 2 replies; 4+ messages in thread
From: David Miller @ 2013-05-26 6:11 UTC (permalink / raw)
To: kyle; +Cc: netdev, richardcochran
From: Kyle McMartin <kyle@redhat.com>
Date: Sat, 25 May 2013 12:55:07 -0400
> It's only accessible via PCI, but has no dependencies, so it ends up
> being selected on s390 where a bunch of primitives only exist if
> CONFIG_PCI=y (such as {request,free}_irq)
>
> Signed-off-by: Kyle McMartin <kyle@redhat.com>
I've already told the s390 people they have to fix this properly.
They have to provide stubs for request_irq() et al. when CONFIG_PCI
is not enabled.
This Kconfig change is therefore not appropriate.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] ptp_pch: depends on PCI
2013-05-26 6:11 ` David Miller
@ 2013-05-26 16:20 ` Kyle McMartin
2013-05-27 14:33 ` Ben Hutchings
1 sibling, 0 replies; 4+ messages in thread
From: Kyle McMartin @ 2013-05-26 16:20 UTC (permalink / raw)
To: David Miller; +Cc: netdev, richardcochran
On Sat, May 25, 2013 at 11:11:29PM -0700, David Miller wrote:
> I've already told the s390 people they have to fix this properly.
>
> They have to provide stubs for request_irq() et al. when CONFIG_PCI
> is not enabled.
>
> This Kconfig change is therefore not appropriate.
OK. Thanks Dave.
regards, Kyle
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ptp_pch: depends on PCI
2013-05-26 6:11 ` David Miller
2013-05-26 16:20 ` Kyle McMartin
@ 2013-05-27 14:33 ` Ben Hutchings
1 sibling, 0 replies; 4+ messages in thread
From: Ben Hutchings @ 2013-05-27 14:33 UTC (permalink / raw)
To: David Miller; +Cc: kyle, netdev, richardcochran
On Sat, 2013-05-25 at 23:11 -0700, David Miller wrote:
> From: Kyle McMartin <kyle@redhat.com>
> Date: Sat, 25 May 2013 12:55:07 -0400
>
> > It's only accessible via PCI, but has no dependencies, so it ends up
> > being selected on s390 where a bunch of primitives only exist if
> > CONFIG_PCI=y (such as {request,free}_irq)
> >
> > Signed-off-by: Kyle McMartin <kyle@redhat.com>
>
> I've already told the s390 people they have to fix this properly.
>
> They have to provide stubs for request_irq() et al. when CONFIG_PCI
> is not enabled.
>
> This Kconfig change is therefore not appropriate.
You are quite right about request_irq(), but this is a PCI driver.
Ben.
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-05-27 14:33 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-25 16:55 [PATCH] ptp_pch: depends on PCI Kyle McMartin
2013-05-26 6:11 ` David Miller
2013-05-26 16:20 ` Kyle McMartin
2013-05-27 14:33 ` Ben Hutchings
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).