* [PATCH V2 3/4] net: wireless: remove unnecessary platform_set_drvdata()
@ 2013-05-28 5:07 Jingoo Han
2013-05-28 5:37 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Jingoo Han @ 2013-05-28 5:07 UTC (permalink / raw)
To: 'David S. Miller'
Cc: netdev, Jingoo Han, 'John W. Linville',
'Jiri Slaby', 'Nick Kossifidis',
'Luis R. Rodriguez', 'Jouni Malinen',
'Vasanthakumar Thiagarajan',
'Senthil Balasubramanian'
The driver core clears the driver data to NULL after device_release
or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
(device-core: Ensure drvdata = NULL when no driver is bound).
Thus, it is not needed to manually clear the device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/net/wireless/ath/ath5k/ahb.c | 2 --
drivers/net/wireless/ath/ath9k/ahb.c | 2 --
2 files changed, 4 deletions(-)
diff --git a/drivers/net/wireless/ath/ath5k/ahb.c b/drivers/net/wireless/ath/ath5k/ahb.c
index 8e8bcc7a..e9bc9e6 100644
--- a/drivers/net/wireless/ath/ath5k/ahb.c
+++ b/drivers/net/wireless/ath/ath5k/ahb.c
@@ -185,7 +185,6 @@ static int ath_ahb_probe(struct platform_device *pdev)
err_free_hw:
ieee80211_free_hw(hw);
- platform_set_drvdata(pdev, NULL);
err_iounmap:
iounmap(mem);
err_out:
@@ -221,7 +220,6 @@ static int ath_ahb_remove(struct platform_device *pdev)
ath5k_deinit_ah(ah);
iounmap(ah->iobase);
- platform_set_drvdata(pdev, NULL);
ieee80211_free_hw(hw);
return 0;
diff --git a/drivers/net/wireless/ath/ath9k/ahb.c b/drivers/net/wireless/ath/ath9k/ahb.c
index d1ff3c2..072e4b5 100644
--- a/drivers/net/wireless/ath/ath9k/ahb.c
+++ b/drivers/net/wireless/ath/ath9k/ahb.c
@@ -150,7 +150,6 @@ static int ath_ahb_probe(struct platform_device *pdev)
free_irq(irq, sc);
err_free_hw:
ieee80211_free_hw(hw);
- platform_set_drvdata(pdev, NULL);
return ret;
}
@@ -164,7 +163,6 @@ static int ath_ahb_remove(struct platform_device *pdev)
ath9k_deinit_device(sc);
free_irq(sc->irq, sc);
ieee80211_free_hw(sc->hw);
- platform_set_drvdata(pdev, NULL);
}
return 0;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH V2 3/4] net: wireless: remove unnecessary platform_set_drvdata()
2013-05-28 5:07 [PATCH V2 3/4] net: wireless: remove unnecessary platform_set_drvdata() Jingoo Han
@ 2013-05-28 5:37 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2013-05-28 5:37 UTC (permalink / raw)
To: jg1.han
Cc: netdev, linville, jirislaby, mickflemm, mcgrof, jouni, vthiagar,
senthilb
From: Jingoo Han <jg1.han@samsung.com>
Date: Tue, 28 May 2013 14:07:11 +0900
> The driver core clears the driver data to NULL after device_release
> or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
> (device-core: Ensure drvdata = NULL when no driver is bound).
> Thus, it is not needed to manually clear the device driver data to NULL.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-05-28 5:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-28 5:07 [PATCH V2 3/4] net: wireless: remove unnecessary platform_set_drvdata() Jingoo Han
2013-05-28 5:37 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).