From: Stephen Hemminger <stephen@networkplumber.org>
To: Cong Wang <amwang@redhat.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>
Subject: Re: [Patch net-next 1/3] vxlan: remove the unused rcu head from struct vxlan_rdst
Date: Tue, 28 May 2013 09:07:06 -0700 [thread overview]
Message-ID: <20130528090706.0d4e9bee@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <1369730153-11214-1-git-send-email-amwang@redhat.com>
On Tue, 28 May 2013 16:35:51 +0800
Cong Wang <amwang@redhat.com> wrote:
> From: Cong Wang <amwang@redhat.com>
>
> Cc: Stephen Hemminger <stephen@networkplumber.org>
> Cc: David S. Miller <davem@davemloft.net>
> Signed-off-by: Cong Wang <amwang@redhat.com>
> ---
> drivers/net/vxlan.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c
> index 5ed64d4..289d79a 100644
> --- a/drivers/net/vxlan.c
> +++ b/drivers/net/vxlan.c
> @@ -97,7 +97,6 @@ struct vxlan_net {
> };
>
> struct vxlan_rdst {
> - struct rcu_head rcu;
> __be32 remote_ip;
> __be16 remote_port;
> u32 remote_vni;
Correct, rdst is freed with fdb and that is already
in RCU call back
Acked-by: Stephen Hemminger <stephen@networkplumber.org>
next prev parent reply other threads:[~2013-05-28 16:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-28 8:35 [Patch net-next 1/3] vxlan: remove the unused rcu head from struct vxlan_rdst Cong Wang
2013-05-28 8:35 ` [Patch net-next 2/3] vxlan: use unsigned int instead of unsigned Cong Wang
2013-05-29 6:54 ` David Miller
2013-05-28 8:35 ` [Patch net-next 3/3] vxlan: defer vxlan init as late as possible Cong Wang
2013-05-29 6:54 ` David Miller
2013-05-28 16:07 ` Stephen Hemminger [this message]
2013-05-29 6:54 ` [Patch net-next 1/3] vxlan: remove the unused rcu head from struct vxlan_rdst David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130528090706.0d4e9bee@nehalam.linuxnetplumber.net \
--to=stephen@networkplumber.org \
--cc=amwang@redhat.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).