netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Richard Cochran <richardcochran@gmail.com>
To: "Keller, Jacob E" <jacob.e.keller@intel.com>
Cc: "Vick, Matthew" <matthew.vick@intel.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	David Miller <davem@davemloft.net>,
	"e1000-devel@lists.sourceforge.net"
	<e1000-devel@lists.sourceforge.net>,
	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@intel.com>
Subject: Re: [PATCH net-next 4/4] igb: enable auxiliary PHC functions for the i210.
Date: Wed, 29 May 2013 09:24:45 +0200	[thread overview]
Message-ID: <20130529072445.GA4868@netboy> (raw)
In-Reply-To: <02874ECE860811409154E81DA85FBB58564F1C88@ORSMSX104.amr.corp.intel.com>

On Tue, May 28, 2013 at 09:12:02PM +0000, Keller, Jacob E wrote:
> 
> I think ethtool would be good, but what about using sysfs?

The problem I see with ethtool is that configuring GPIOs (and these
SDPs are really just GPIOs by a different name) is really the job of
the device tree. But of course, most x86 users of the i210 don't have
this option.

Also, using ethtool or sysfs is not really attractive for embedded
designs (let's not forget the poor embedded guys). I think we need to
have a way to specify the pin functions at (or before) kernel boot
time.  Barring DT and kconfig, using a module parameter is the only
way to accomplish this.

Thanks,
Richard

  reply	other threads:[~2013-05-29  7:24 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-27  9:21 [PATCH net-next 0/4] igb: auxiliary PHC functions for the i210 Richard Cochran
2013-05-27  9:21 ` [PATCH net-next 1/4] igb: refactor and simplify time sync interrupt handling Richard Cochran
2013-05-28  0:44   ` Jeff Kirsher
2013-05-28 15:24   ` Vick, Matthew
2013-05-27  9:21 ` [PATCH net-next 2/4] igb: add more register definitions for time sync functions Richard Cochran
2013-05-28  0:44   ` Jeff Kirsher
2013-05-27  9:21 ` [PATCH net-next 3/4] igb: do not clobber the TSAUXC bits on reset Richard Cochran
2013-05-28  0:44   ` Jeff Kirsher
2013-05-27  9:21 ` [PATCH net-next 4/4] igb: enable auxiliary PHC functions for the i210 Richard Cochran
2013-05-28  0:45   ` Jeff Kirsher
2013-05-28 15:58   ` Vick, Matthew
2013-05-28 16:23     ` Richard Cochran
2013-05-28 17:39       ` [E1000-devel] " Alexander Duyck
2013-05-28 17:49       ` Vick, Matthew
2013-05-28 21:12         ` Keller, Jacob E
2013-05-29  7:24           ` Richard Cochran [this message]
2013-05-29  7:34             ` David Miller
2013-05-29 20:32             ` Ben Hutchings
2013-05-28 15:58 ` [PATCH net-next 0/4] igb: " Vick, Matthew
  -- strict thread matches above, loose matches on Subject: below --
2014-11-17 23:06 Richard Cochran
2014-11-17 23:06 ` [PATCH net-next 4/4] igb: enable " Richard Cochran
2014-11-17 23:28   ` Keller, Jacob E

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130529072445.GA4868@netboy \
    --to=richardcochran@gmail.com \
    --cc=davem@davemloft.net \
    --cc=e1000-devel@lists.sourceforge.net \
    --cc=jacob.e.keller@intel.com \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=matthew.vick@intel.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).