From: Jesper Dangaard Brouer <brouer-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Stephen Hemminger
<stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org>,
Eric Dumazet
<eric.dumazet-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
David Miller <davem-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
j.vimal-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
Michal Soltys <soltys-R61QfzASbfY@public.gmane.org>,
Mike Frysinger <vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org>,
Jussi Kivilinna <jussi.kivilinna-E01nCVcF24I@public.gmane.org>,
Patrick McHardy <kaber-dcUjhNyLwpNeoWH0uzbU5w@public.gmane.org>,
Jiri Pirko <jpirko-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: "Toke Høiland-Jørgensen" <toke-LJ9M9ZcSy1A@public.gmane.org>,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
"Steven Barth" <cyrus-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>,
bloat-JXvr2/1DY2fm6VMwtOF2vx4hnT+Y9+D1@public.gmane.org,
"Jiri Benc" <jbenc-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
"Felix Fietkau" <nbd-Vt+b4OUoWG0@public.gmane.org>
Subject: tc linklayer ADSL calc broken after commit 56b765b79 (htb: improved accuracy at high rates)
Date: Wed, 29 May 2013 15:13:30 +0200 [thread overview]
Message-ID: <20130529151330.22c5c89e@redhat.com> (raw)
I recently discovered that the (traffic control) tc linklayer
calculations for ATM/ADSL have been broken by:
commit 56b765b79 (htb: improved accuracy at high rates).
Thus, people shaping on ADSL links, using e.g.:
tc class add ... htb rate X ceil Y linklayer atm overhead 10
Will no-longer get ATM cell tax/overhead adjusted.
How can we solve/fix this?
Perhaps we can change to use the "stab" system instead (as it does
not seem to be broken by the commit).
But how do we facilitate a change to use "stab" system (for all the
scripts using the old option)?
Can we change the iproute2/tc command to handle this transparently, or
should we give an error/warning if someone uses "tc" and "linklayer" on
a kernel above v.3.8. ?
History:
- My linklayer ATM changes appeared in kernel 2.6.24 (and iproute2 2.6.25)
- The STAB changes appeared in kernel 2.6.27
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Sr. Network Kernel Developer at Red Hat
Author of http://www.iptv-analyzer.org
LinkedIn: http://www.linkedin.com/in/brouer
next reply other threads:[~2013-05-29 13:13 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-29 13:13 Jesper Dangaard Brouer [this message]
2013-05-29 15:52 ` tc linklayer ADSL calc broken after commit 56b765b79 (htb: improved accuracy at high rates) Eric Dumazet
2013-05-29 22:50 ` Stephen Hemminger
2013-05-29 23:18 ` Eric Dumazet
2013-05-30 9:15 ` Jesper Dangaard Brouer
2013-05-30 9:52 ` [Bloat] " Steinar H. Gunderson
[not found] ` <20130529155034.334092c5-We1ePj4FEcvRI77zikRAJc56i+j3xesD0e7PPNI6Mm0@public.gmane.org>
2013-05-30 0:34 ` Dave Taht
2013-05-30 8:09 ` Jesper Dangaard Brouer
2013-05-30 7:51 ` Jesper Dangaard Brouer
2013-05-30 14:39 ` Eric Dumazet
2013-05-30 15:55 ` Jesper Dangaard Brouer
2013-05-30 16:29 ` Jussi Kivilinna
2013-06-02 21:15 ` Eric Dumazet
2013-06-02 21:33 ` [PATCH iproute2] htb: report overhead attribute Eric Dumazet
2013-06-03 15:45 ` Rick Jones
2013-06-03 15:56 ` Eric Dumazet
2013-06-04 11:11 ` Jesper Dangaard Brouer
2013-06-04 13:58 ` Eric Dumazet
2013-06-04 15:08 ` Jesper Dangaard Brouer
2013-06-03 19:50 ` Jussi Kivilinna
2013-06-07 15:56 ` Stephen Hemminger
2013-06-07 16:00 ` Eric Dumazet
2013-06-04 12:13 ` Bad shaping at low rates, after commit 56b765b79 (htb: improved accuracy at high rates) Jesper Dangaard Brouer
2013-06-04 15:18 ` Eric Dumazet
2013-06-04 15:55 ` Eric Dumazet
2013-06-04 16:02 ` Eric Dumazet
2013-06-04 17:11 ` [PATCH] net_sched: htb: do not mix 1ns and 64ns time units Eric Dumazet
2013-06-04 20:21 ` Jesper Dangaard Brouer
[not found] ` <20130604222135.67eedab8-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-06-04 20:26 ` Dave Taht
2013-06-04 21:02 ` Eric Dumazet
2013-06-04 20:50 ` Eric Dumazet
2013-06-05 0:44 ` David Miller
2013-06-06 13:55 ` RFC: Proposed fix for tc linklayer calc broken after commit 56b765b79 (htb: improved accuracy at high rates) Jesper Dangaard Brouer
2013-06-06 14:28 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130529151330.22c5c89e@redhat.com \
--to=brouer-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=bloat-JXvr2/1DY2fm6VMwtOF2vx4hnT+Y9+D1@public.gmane.org \
--cc=cyrus-p3rKhJxN3npAfugRpC6u6w@public.gmane.org \
--cc=davem-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=eric.dumazet-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=j.vimal-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=jbenc-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=jpirko-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=jussi.kivilinna-E01nCVcF24I@public.gmane.org \
--cc=kaber-dcUjhNyLwpNeoWH0uzbU5w@public.gmane.org \
--cc=nbd-Vt+b4OUoWG0@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=soltys-R61QfzASbfY@public.gmane.org \
--cc=stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org \
--cc=toke-LJ9M9ZcSy1A@public.gmane.org \
--cc=vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).