From: Simon Horman <horms@verge.net.au>
To: Olof Johansson <olof@lixom.net>
Cc: dev <dev@openvswitch.org>,
"Network Development" <netdev@vger.kernel.org>,
"Jesse Gross" <jesse@nicira.com>,
"Pravin B Shelar" <pshelar@nicira.com>,
"jarno.rajahalme" <jarno.rajahalme@nsn.com>,
"Eric Dumazet" <eric.dumazet@gmail.com>,
"Maciej Żenczykowski" <maze@google.com>,
"David Miller" <davem@davemloft.net>
Subject: Re: [PATCH net-next v5 1/2] net: Use 16bits for *_headers fields of struct skbuff
Date: Thu, 30 May 2013 12:00:53 +0900 [thread overview]
Message-ID: <20130530030042.GD6475@verge.net.au> (raw)
In-Reply-To: <CAOesGMjuOaSr6vG+bPQGAdNKa4yeAOFLA+eyBHS+rDvevQASHQ@mail.gmail.com>
On Wed, May 29, 2013 at 04:02:12PM -0700, Olof Johansson wrote:
> Hi,
>
> On Wed, May 29, 2013 at 3:54 PM, Simon Horman <horms@verge.net.au> wrote:
> > On Wed, May 29, 2013 at 02:46:05PM -0700, Olof Johansson wrote:
> >> Sorry, that was not a great bug report.
> >>
> >> So, looks like it's the removal of NET_SKBUFF_DATA_USES_OFFSET that
> >> does it for me.
> >>
> >> The devices I've seen it with are with asix usb-ethernet adapters (on
> >> Tegra seaboard) and with mv643xx_eth on cubox (dove).
> >>
> >> I'll try to get a better stacktrace out of it. Simon, maybe you can
> >> reproduce on shmobile hardware?
> >
> > Sure, I will try and reproduce it.
> >
> > I did subsequently post some fixes for fallout resulting from
> > the patch listed below. Those changes are now net-next.
> > Are you seeing the crash with those patches?
> >
> > The fix-up patches are:
> >
> > net,ipv4,ipv6: Correct assignment of skb->network_header to skb->tail
> > sctp: Correct access to skb->{network,transport}_header
> > ipv4: Correct comparisons and calculations using skb->tail and skb-transport_header
> > ipv6: Correct comparisons and calculations using skb->tail and skb-transport_header
> > net: Correct comparisons and calculations using skb->tail and skb-transport_header
> > cxgb3: Correct comparisons and calculations using skb->tail and skb-transport_header
> > isdn: Correct comparison of skb->tail and skb-transport_header
> > net: Fix build warnings after mac_header and transport_header became __u16.
>
> Ah, no, looks like those didn't make it into the 0529 linux-next.
>
> I've merged net-next on top and retested, and I no longer see the panics.
Great news, sorry for the mess.
FWIW I did not have any luck reproducing the problem (without the fix-ups)
on the mackerel board.
next prev parent reply other threads:[~2013-05-30 3:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-24 6:51 [PATCH next-next v4 0/2] MPLS: Add limited GSO support Simon Horman
2013-05-24 6:51 ` [PATCH net-next v5 1/2] net: Use 16bits for *_headers fields of struct skbuff Simon Horman
2013-05-29 21:21 ` Olof Johansson
[not found] ` <CAOesGMg2-CgJeqFM7K1QBAhG+xOc33t0vV1xR1J_4-iJJ58r8A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-05-29 21:46 ` Olof Johansson
2013-05-29 22:54 ` Simon Horman
2013-05-29 23:02 ` Olof Johansson
2013-05-30 3:00 ` Simon Horman [this message]
2013-05-24 6:51 ` [PATCH net-next v5 2/2] MPLS: Add limited GSO support Simon Horman
2013-05-24 7:01 ` [PATCH next-next v4 0/2] " Simon Horman
2013-05-24 7:12 ` Zhi Yong Wu
2013-05-25 0:02 ` Simon Horman
-- strict thread matches above, loose matches on Subject: below --
2013-05-24 7:02 [PATCH net-next v5 " Simon Horman
[not found] ` <1369378972-22728-1-git-send-email-horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>
2013-05-24 7:02 ` [PATCH net-next v5 1/2] net: Use 16bits for *_headers fields of struct skbuff Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130530030042.GD6475@verge.net.au \
--to=horms@verge.net.au \
--cc=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=eric.dumazet@gmail.com \
--cc=jarno.rajahalme@nsn.com \
--cc=jesse@nicira.com \
--cc=maze@google.com \
--cc=netdev@vger.kernel.org \
--cc=olof@lixom.net \
--cc=pshelar@nicira.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).