From: David Miller <davem@davemloft.net>
To: alanr@unix.sh
Cc: netdev@vger.kernel.org, davem@gavemloft.net,
kuznet@ms2.inr.ac.ru, vyasevic@redhat.com
Subject: Re: [PATCH net] rtnetlink: ndo_dflt_fdb_del() never works
Date: Fri, 31 May 2013 01:46:07 -0700 (PDT) [thread overview]
Message-ID: <20130531.014607.358769391044586124.davem@davemloft.net> (raw)
In-Reply-To: <1369951315-14742-1-git-send-email-alanr@unix.sh>
From: Alan Robertson <alanr@unix.sh>
Date: Thu, 30 May 2013 16:01:55 -0600
> ndo_dflt_fdb_del is checking for a condition which is opposite that
> which ndo_dflt_fdb_add enforces. ndo_dflt_fdb_add declares an error
> if (ndm->ndm_state && !(ndm->ndm_state) & NUD_PERMANENT)) - that is, if the
> entry is static. This is consistent with the failure error message.
>
> On the other hand, ndo_dflt_del() declares an error
> if (ndm_state & NUD_PERMANENT) - which is inconsistent with the add
> precondition, and inconsistent with its failure message text.
> As it is now, you can't delete any entry which add allows to be added -
> so entry deletion always fails.
>
> Signed-off-by: Alan Robertson <alanr@unix.sh>
What about the ->ndm_state part of the add() test? Why not include
that in the del() check?
next prev parent reply other threads:[~2013-05-31 8:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-30 22:01 [PATCH net] rtnetlink: ndo_dflt_fdb_del() never works Alan Robertson
2013-05-31 8:46 ` David Miller [this message]
2013-05-31 16:43 ` Alan Robertson
2013-05-31 17:11 ` Vlad Yasevich
2013-05-31 19:59 ` Alan Robertson
2013-05-31 23:42 ` David Miller
2013-06-03 21:40 ` Alan Robertson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130531.014607.358769391044586124.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alanr@unix.sh \
--cc=davem@gavemloft.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
--cc=vyasevic@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).