From: David Miller <davem@davemloft.net>
To: horms@verge.net.au
Cc: pablo@netfilter.org, netdev@vger.kernel.org,
netfilter-devel@vger.kernel.org, gang.chen@asianux.com
Subject: Re: [PATCH net-next v3] netfilter: Correct calculation using skb->tail and skb-network_header
Date: Fri, 31 May 2013 16:38:50 -0700 (PDT) [thread overview]
Message-ID: <20130531.163850.493455196018855311.davem@davemloft.net> (raw)
In-Reply-To: <1369967969-32375-1-git-send-email-horms@verge.net.au>
From: Simon Horman <horms@verge.net.au>
Date: Fri, 31 May 2013 11:39:29 +0900
> This corrects an regression introduced by "net: Use 16bits for *_headers
> fields of struct skbuff" when NET_SKBUFF_DATA_USES_OFFSET is not set. In
> that case skb->tail will be a pointer whereas skb->network_header
> will be an offset from head. This is corrected by using wrappers that
> ensure that calculations are always made using pointers.
>
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Reported-by: Chen Gang <gang.chen@asianux.com>
> Signed-off-by: Simon Horman <horms@verge.net.au>
I've applied this directly to net-next, thanks Simon.
next prev parent reply other threads:[~2013-05-31 23:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-31 2:39 [PATCH net-next v3] netfilter: Correct calculation using skb->tail and skb-network_header Simon Horman
2013-05-31 23:38 ` David Miller [this message]
2013-06-03 9:06 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130531.163850.493455196018855311.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=gang.chen@asianux.com \
--cc=horms@verge.net.au \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).