From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: bhutchings@solarflare.com, netdev@vger.kernel.org,
hkchu@google.com, herbert@gondor.apana.org.au
Subject: Re: [PATCH v2 net-next] gro: should aggregate frames without DF
Date: Fri, 31 May 2013 17:15:00 -0700 (PDT) [thread overview]
Message-ID: <20130531.171500.2100142825483179922.davem@davemloft.net> (raw)
In-Reply-To: <1370035090.5109.113.camel@edumazet-glaptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Fri, 31 May 2013 14:18:10 -0700
> From: Eric Dumazet <edumazet@google.com>
>
> GRO on IPv4 doesn't aggregate frames if they don't have DF bit set.
>
> Some servers use IP_MTU_DISCOVER/IP_PMTUDISC_PROBE, so linux receivers
> are unable to aggregate this kind of traffic.
>
> The right thing to do is to allow aggregation as long as the DF bit has
> same value on all segments.
>
> bnx2x LRO does this correctly.
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Applied, thanks.
prev parent reply other threads:[~2013-06-01 0:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-31 17:02 [PATCH net-next] gro: should aggregate frames without DF Eric Dumazet
2013-05-31 18:14 ` Jerry Chu
2013-05-31 20:09 ` Ben Hutchings
2013-05-31 21:12 ` Eric Dumazet
2013-05-31 21:18 ` [PATCH v2 " Eric Dumazet
2013-05-31 21:27 ` Ben Hutchings
2013-06-01 0:15 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130531.171500.2100142825483179922.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bhutchings@solarflare.com \
--cc=eric.dumazet@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=hkchu@google.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).