Netdev List
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: dmitry@broadcom.com
Cc: eric.dumazet@gmail.com, netdev@vger.kernel.org,
	govindarajulu90@gmail.com, hskinnemoen@google.com,
	eilong@broadcom.com
Subject: Re: [PATCH net-next] bnx2x: use XPS if possible for bnx2x_select_queue instead of pure hash
Date: Sat, 01 Jun 2013 19:38:57 -0700 (PDT)	[thread overview]
Message-ID: <20130601.193857.1132434060524891436.davem@davemloft.net> (raw)
In-Reply-To: <504C9EFCA2D0054393414C9CB605C37F20C955D6@SJEXCHMB06.corp.ad.broadcom.com>

From: "Dmitry Kravkov" <dmitry@broadcom.com>
Date: Sat, 1 Jun 2013 11:27:40 +0000

>> The bnx2x_select_queue() was using __skb_tx_hash() to select the
>> transmit queue, totally ignoring XPS settings, while XPS can help
>> performance quite significantly, so change the bnx2x_select_queue()
>> to use __dev_pick_tx() instead which will use XPS if configured.
>> 
>> Based on patches from Ying Cai and Havard Skinnemoen
>> 
>> Reported-by: govindarajulu.v <govindarajulu90@gmail.com>
>> Signed-off-by: Eric Dumazet <edumazet@google.com>
 ...
> Acked-by: Dmitry Kravkov <dmitry@broadcom.com>

Applied, thanks everyone.

      reply	other threads:[~2013-06-02  2:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-01  0:32 [PATCH net-next] bnx2x: use XPS if possible for bnx2x_select_queue instead of pure hash Eric Dumazet
2013-06-01 11:27 ` Dmitry Kravkov
2013-06-02  2:38   ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130601.193857.1132434060524891436.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=dmitry@broadcom.com \
    --cc=eilong@broadcom.com \
    --cc=eric.dumazet@gmail.com \
    --cc=govindarajulu90@gmail.com \
    --cc=hskinnemoen@google.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox