From: David Miller <davem@davemloft.net>
To: joe@perches.com
Cc: lorenzo@google.com, netdev@vger.kernel.org, edumazet@google.com,
yoshfuji@linux-ipv6.org, segoon@openwall.com
Subject: Re: [PATCH v4 1/4] Clean up indentation in net/ipv6/transp_v6.h
Date: Sat, 01 Jun 2013 19:58:06 -0700 (PDT) [thread overview]
Message-ID: <20130601.195806.2024506377665086082.davem@davemloft.net> (raw)
In-Reply-To: <1370049940.10556.100.camel@joe-AO722>
From: Joe Perches <joe@perches.com>
Date: Fri, 31 May 2013 18:25:40 -0700
> externs aren't useful here and I suggest prototypes like
> int ipv6_exthdrs_init(void);
But this is the format used by the entire header file, all functions
are declared extern.
It is not reasonable to ask him to change this. It's a seperate
cleanup, and that's assuming we actually agree to remove the externs.
I honestly see no reason to, they are harmless, and given that it's
just pure churn.
next prev parent reply other threads:[~2013-06-02 2:58 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-01 1:05 [PATCH v4 1/4] Clean up indentation in net/ipv6/transp_v6.h Lorenzo Colitti
2013-06-01 1:05 ` [PATCH v4 2/4] net: ipv6: Unify {raw,udp}6_sock_seq_show Lorenzo Colitti
2013-06-04 19:56 ` David Miller
2013-06-01 1:05 ` [PATCH v4 3/4] net: ipv4: make the ping /proc code AF-independent Lorenzo Colitti
2013-06-04 19:57 ` David Miller
2013-06-01 1:05 ` [PATCH v4 4/4] net: ipv6: Implement /proc/net/icmp6 Lorenzo Colitti
2013-06-04 19:57 ` David Miller
2013-06-01 1:25 ` [PATCH v4 1/4] Clean up indentation in net/ipv6/transp_v6.h Joe Perches
2013-06-02 2:58 ` David Miller [this message]
2013-06-02 3:06 ` Joe Perches
2013-06-02 3:44 ` Lorenzo Colitti
2013-06-02 3:52 ` Joe Perches
2013-06-02 8:29 ` David Miller
2013-06-02 9:23 ` Joe Perches
2013-06-02 10:35 ` Lorenzo Colitti
2013-06-02 17:04 ` [PATCH net-next post Lorenzo] transp_v6.h: style neatening Joe Perches
2013-06-03 2:20 ` Lorenzo Colitti
2013-06-03 2:34 ` Joe Perches
2013-06-02 14:16 ` [PATCH v4 1/4] Clean up indentation in net/ipv6/transp_v6.h Eric Dumazet
2013-06-02 17:30 ` Joe Perches
2013-06-04 19:56 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130601.195806.2024506377665086082.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=joe@perches.com \
--cc=lorenzo@google.com \
--cc=netdev@vger.kernel.org \
--cc=segoon@openwall.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).