From: "Michael Büsch" <m@bues.ch>
To: Jingoo Han <jg1.han@samsung.com>
Cc: netdev@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>,
"'David S. Miller'" <davem@davemloft.net>
Subject: Re: [PATCH] ssb: sprom: replace strict_strtoul() with kstrtoul()
Date: Sat, 1 Jun 2013 11:10:55 +0200 [thread overview]
Message-ID: <20130601111055.1f9fcf4c@milhouse> (raw)
In-Reply-To: <001601ce5e9a$93bc9fb0$bb35df10$@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 901 bytes --]
On Sat, 01 Jun 2013 16:35:23 +0900
Jingoo Han <jg1.han@samsung.com> wrote:
> The usage of strict_strtoul() is not preferred, because
> strict_strtoul() is obsolete. Thus, kstrtoul() should be
> used.
Looks good. John, can you apply, please?
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/ssb/sprom.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ssb/sprom.c b/drivers/ssb/sprom.c
> index a3b2364..e753fbe 100644
> --- a/drivers/ssb/sprom.c
> +++ b/drivers/ssb/sprom.c
> @@ -54,7 +54,7 @@ static int hex2sprom(u16 *sprom, const char *dump, size_t len,
> while (cnt < sprom_size_words) {
> memcpy(tmp, dump, 4);
> dump += 4;
> - err = strict_strtoul(tmp, 16, &parsed);
> + err = kstrtoul(tmp, 16, &parsed);
> if (err)
> return err;
> sprom[cnt++] = swab16((u16)parsed);
--
Michael
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-06-01 9:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-01 7:35 [PATCH] ssb: sprom: replace strict_strtoul() with kstrtoul() Jingoo Han
2013-06-01 9:10 ` Michael Büsch [this message]
2013-06-03 7:41 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130601111055.1f9fcf4c@milhouse \
--to=m@bues.ch \
--cc=davem@davemloft.net \
--cc=jg1.han@samsung.com \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).