* [PATCH] ssb: sprom: replace strict_strtoul() with kstrtoul()
@ 2013-06-01 7:35 Jingoo Han
2013-06-01 9:10 ` Michael Büsch
2013-06-03 7:41 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Jingoo Han @ 2013-06-01 7:35 UTC (permalink / raw)
To: 'Michael Buesch'
Cc: netdev, Jingoo Han, John W. Linville, 'David S. Miller'
The usage of strict_strtoul() is not preferred, because
strict_strtoul() is obsolete. Thus, kstrtoul() should be
used.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/ssb/sprom.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ssb/sprom.c b/drivers/ssb/sprom.c
index a3b2364..e753fbe 100644
--- a/drivers/ssb/sprom.c
+++ b/drivers/ssb/sprom.c
@@ -54,7 +54,7 @@ static int hex2sprom(u16 *sprom, const char *dump, size_t len,
while (cnt < sprom_size_words) {
memcpy(tmp, dump, 4);
dump += 4;
- err = strict_strtoul(tmp, 16, &parsed);
+ err = kstrtoul(tmp, 16, &parsed);
if (err)
return err;
sprom[cnt++] = swab16((u16)parsed);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ssb: sprom: replace strict_strtoul() with kstrtoul()
2013-06-01 7:35 [PATCH] ssb: sprom: replace strict_strtoul() with kstrtoul() Jingoo Han
@ 2013-06-01 9:10 ` Michael Büsch
2013-06-03 7:41 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Michael Büsch @ 2013-06-01 9:10 UTC (permalink / raw)
To: Jingoo Han; +Cc: netdev, John W. Linville, 'David S. Miller'
[-- Attachment #1: Type: text/plain, Size: 901 bytes --]
On Sat, 01 Jun 2013 16:35:23 +0900
Jingoo Han <jg1.han@samsung.com> wrote:
> The usage of strict_strtoul() is not preferred, because
> strict_strtoul() is obsolete. Thus, kstrtoul() should be
> used.
Looks good. John, can you apply, please?
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/ssb/sprom.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ssb/sprom.c b/drivers/ssb/sprom.c
> index a3b2364..e753fbe 100644
> --- a/drivers/ssb/sprom.c
> +++ b/drivers/ssb/sprom.c
> @@ -54,7 +54,7 @@ static int hex2sprom(u16 *sprom, const char *dump, size_t len,
> while (cnt < sprom_size_words) {
> memcpy(tmp, dump, 4);
> dump += 4;
> - err = strict_strtoul(tmp, 16, &parsed);
> + err = kstrtoul(tmp, 16, &parsed);
> if (err)
> return err;
> sprom[cnt++] = swab16((u16)parsed);
--
Michael
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ssb: sprom: replace strict_strtoul() with kstrtoul()
2013-06-01 7:35 [PATCH] ssb: sprom: replace strict_strtoul() with kstrtoul() Jingoo Han
2013-06-01 9:10 ` Michael Büsch
@ 2013-06-03 7:41 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2013-06-03 7:41 UTC (permalink / raw)
To: jg1.han; +Cc: m, netdev, linville
From: Jingoo Han <jg1.han@samsung.com>
Date: Sat, 01 Jun 2013 16:35:23 +0900
> The usage of strict_strtoul() is not preferred, because
> strict_strtoul() is obsolete. Thus, kstrtoul() should be
> used.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-06-03 7:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-01 7:35 [PATCH] ssb: sprom: replace strict_strtoul() with kstrtoul() Jingoo Han
2013-06-01 9:10 ` Michael Büsch
2013-06-03 7:41 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).