From: David Miller <davem@davemloft.net>
To: linville@tuxdriver.com
Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: pull request: wireless 2013-06-03
Date: Tue, 04 Jun 2013 13:18:13 -0700 (PDT) [thread overview]
Message-ID: <20130604.131813.134898245916084893.davem@davemloft.net> (raw)
In-Reply-To: <20130603184817.GD2727@tuxdriver.com>
From: "John W. Linville" <linville@tuxdriver.com>
Date: Mon, 3 Jun 2013 14:48:17 -0400
> Please let me know if there are problems!
Sorry, the broadcom brcmfmac changes need to go.
Some of those commits are cleanups, and some of them have the worst
commit log messages ever, the last one for example:
0017-brcmsmac-fix-regression-observed-in-3.10-rc1.patch
has no explanation whatsoever of what the actual problem or regression
is, what aspect of the logic in that function is causing the problem,
and no explanation why making this function always return 'false' is a
reasonable fix.
That entire series is of very low quality, and even if it was in good
shape, at least half the changes are not appropriate at all this late
in the -rc series.
next prev parent reply other threads:[~2013-06-04 20:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-03 18:48 pull request: wireless 2013-06-03 John W. Linville
2013-06-04 20:18 ` David Miller [this message]
[not found] ` <20130604.131813.134898245916084893.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2013-06-04 20:56 ` John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130604.131813.134898245916084893.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).