netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: emilgoode@gmail.com
Cc: kuznet@ms2.inr.ac.ru, jmorris@namei.org, yoshfuji@linux-ipv6.org,
	kaber@trash.net, lorenzo@google.com, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] net: ipv6: Fix incompatible pointer type warning
Date: Tue, 04 Jun 2013 17:14:56 -0700 (PDT)	[thread overview]
Message-ID: <20130604.171456.2052649822776872955.davem@davemloft.net> (raw)
In-Reply-To: <1370262068-16658-1-git-send-email-emilgoode@gmail.com>

From: Emil Goode <emilgoode@gmail.com>
Date: Mon,  3 Jun 2013 14:21:08 +0200

> This fixes the sparse warning below about assignment from
> incompatible pointer type.
> 
> In the following commit the third argument in function ipv6_chk_addr
> was changed to const and struct nf_ipv6_ops was introduced with
> the third argument of .chk_addr beeing const.
> 
> 2a7851bffb008ff4882eee673da74718997b4265
> ("netfilter: add nf_ipv6_ops hook to fix xt_addrtype with IPv6")
> 
> The below commit introduced the warning as the third argument of
> dummy_ipv6_chk_addr and .ipv6_chk_addr in struct pingv6_ops is
> missing a const.
> 
> 6d0bfe22611602f36617bc7aa2ffa1bbb2f54c67
> ("net: ipv6: Add IPv6 support to the ping socket.")
> 
> Sparse output:
> 
> net/ipv6/ping.c: In function ‘pingv6_init’:
> net/ipv6/ping.c:87:27: warning:
> 	assignment from incompatible pointer type [enabled by default]
> 
> Signed-off-by: Emil Goode <emilgoode@gmail.com>

This only happens when you combine net with net-next, therefore your
patch isn't actually relevent to any real GIT tree.

Please make this very clear in the future.

  parent reply	other threads:[~2013-06-05  0:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-03 12:21 [PATCH] net: ipv6: Fix incompatible pointer type warning Emil Goode
2013-06-04  9:34 ` Lorenzo Colitti
2013-06-05  0:14 ` David Miller [this message]
2013-06-05 10:23   ` Emil Goode

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130604.171456.2052649822776872955.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=emilgoode@gmail.com \
    --cc=jmorris@namei.org \
    --cc=kaber@trash.net \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=kuznet@ms2.inr.ac.ru \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lorenzo@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).