From: David Miller <davem@davemloft.net>
To: horms@verge.net.au
Cc: roy.qing.li@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] cxgb3: Correct comparisons and calculations using skb->tail and skb-transport_header
Date: Tue, 04 Jun 2013 17:38:37 -0700 (PDT) [thread overview]
Message-ID: <20130604.173837.694607398273174665.davem@davemloft.net> (raw)
In-Reply-To: <20130604132353.GF3068@verge.net.au>
From: Simon Horman <horms@verge.net.au>
Date: Tue, 4 Jun 2013 22:23:53 +0900
> On Tue, Jun 04, 2013 at 04:11:16PM +0800, roy.qing.li@gmail.com wrote:
>> From: Li RongQing <roy.qing.li@gmail.com>
>>
>> This corrects an regression introduced by "net: Use 16bits for *_headers
>> fields of struct skbuff" when NET_SKBUFF_DATA_USES_OFFSET is not set. In
>> that case skb->tail will be a pointer whereas skb->transport_header
>> will be an offset from head. This is corrected by using wrappers that
>> ensure that comparisons and calculations are always made using pointers.
>>
>> Cc: Simon Horman <horms@verge.net.au>
>> Signed-off-by: Li RongQing <roy.qing.li@gmail.com>
>
> Reviewed-by: Simon Horman <horms@verge.net.au>
Applied.
prev parent reply other threads:[~2013-06-05 0:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-04 8:11 [PATCH net-next] cxgb3: Correct comparisons and calculations using skb->tail and skb-transport_header roy.qing.li
2013-06-04 13:23 ` Simon Horman
2013-06-05 0:38 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130604.173837.694607398273174665.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=horms@verge.net.au \
--cc=netdev@vger.kernel.org \
--cc=roy.qing.li@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).