From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Stefan Roese <sr@denx.de>,
Richard Genoud <richard.genoud@gmail.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] net: sun4i-emac: remove erroneous assignment
Date: Tue, 4 Jun 2013 15:40:34 +0200 [thread overview]
Message-ID: <20130604134034.GE3283@lukather> (raw)
In-Reply-To: <3298610.K0DeJZEM4E@wuerfel>
Hi Arnd,
On Mon, Jun 03, 2013 at 11:36:50PM +0200, Arnd Bergmann wrote:
> The newly added sun4i-emac driver causes a build error when
> CONFIG_NET_POLL_CONTROLLER is set, because it attempts to
> assign a pointer to netdev->poll_controller, which has
> been replaced with ops->ndo_poll_controller in 2.6.31!
>
> The correct assignment is present as well, so we just need
> to remove the wrong one.
Thanks for fixing this,
Acked-by: Maxime Ripard <maxime.ripard@anandra.org>
Maxime
next prev parent reply other threads:[~2013-06-04 13:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-03 21:36 [PATCH] net: sun4i-emac: remove erroneous assignment Arnd Bergmann
2013-06-04 5:52 ` Stefan Roese
2013-06-04 13:40 ` Maxime Ripard [this message]
2013-06-05 0:34 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130604134034.GE3283@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=richard.genoud@gmail.com \
--cc=sr@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).