From: Steffen Klassert <steffen.klassert@secunet.com>
To: Fan Du <fan.du@windriver.com>
Cc: herbert@gondor.hengli.com.au, davem@davemloft.net,
netdev@vger.kernel.org
Subject: Re: [PATCHv3 net-next] xfrm: add LINUX_MIB_XFRMACQUIREERROR statistic counter
Date: Thu, 6 Jun 2013 14:23:50 +0200 [thread overview]
Message-ID: <20130606122350.GC3109@secunet.com> (raw)
In-Reply-To: <1370484954-30023-1-git-send-email-fan.du@windriver.com>
On Thu, Jun 06, 2013 at 10:15:54AM +0800, Fan Du wrote:
> When host ping its peer, ICMP echo request packet triggers IPsec
> policy, then host negotiates SA secret with its peer. After IKE
> installed SA for OUT direction, but before SA for IN direction
> installed, host get ICMP echo reply from its peer. At the time
> being, the SA state for IN direction could be XFRM_STATE_ACQ,
> then the received packet will be dropped after adding
> LINUX_MIB_XFRMINSTATEINVALID statistic.
>
> Adding a LINUX_MIB_XFRMACQUIREERROR statistic counter for such
> scenario when SA in larval state is much clearer for user than
> LINUX_MIB_XFRMINSTATEINVALID which indicates the SA is totally
> bad.
>
> Signed-off-by: Fan Du <fan.du@windriver.com>
Applied to ipsec-next.
Thanks!
prev parent reply other threads:[~2013-06-06 12:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-06 2:15 [PATCHv3 net-next] xfrm: add LINUX_MIB_XFRMACQUIREERROR statistic counter Fan Du
2013-06-06 12:23 ` Steffen Klassert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130606122350.GC3109@secunet.com \
--to=steffen.klassert@secunet.com \
--cc=davem@davemloft.net \
--cc=fan.du@windriver.com \
--cc=herbert@gondor.hengli.com.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).