From: David Miller <davem@davemloft.net>
To: JBeulich@suse.com
Cc: ian.campbell@citrix.com, xen-devel@lists.xen.org, netdev@vger.kernel.org
Subject: Re: [PATCH] xen-netback: don't de-reference vif pointer after having called xenvif_put()
Date: Tue, 11 Jun 2013 02:01:36 -0700 (PDT) [thread overview]
Message-ID: <20130611.020136.1037505762134627955.davem@davemloft.net> (raw)
In-Reply-To: <51AF613F02000078000DB84E@nat28.tlf.novell.com>
From: "Jan Beulich" <JBeulich@suse.com>
Date: Wed, 05 Jun 2013 15:03:11 +0100
> When putting vif-s on the rx notify list, calling xenvif_put() must be
> deferred until after the removal from the list and the issuing of the
> notification, as both operations dereference the pointer.
>
> Changing this got me to notice that the "irq" variable was effectively
> unused (and was of too narrow type anyway).
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
You've included the commit message, and the patch, twice. Once inline
and once as an attachment, do not do this. It makes the patch impossible
to apply when I fetch it out of patchwork.
Please submit it properly.
next prev parent reply other threads:[~2013-06-11 9:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-05 14:03 [PATCH] xen-netback: don't de-reference vif pointer after having called xenvif_put() Jan Beulich
2013-06-05 15:13 ` Ian Campbell
2013-06-11 9:01 ` David Miller [this message]
2013-06-11 9:59 ` Jan Beulich
2013-06-11 20:00 ` David Miller
2013-06-11 10:00 ` [PATCH, resend] " Jan Beulich
2013-06-13 8:25 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130611.020136.1037505762134627955.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=JBeulich@suse.com \
--cc=ian.campbell@citrix.com \
--cc=netdev@vger.kernel.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).