From: David Miller <davem@davemloft.net>
To: amwang@redhat.com
Cc: netdev@vger.kernel.org, eric.dumazet@gmail.com,
rick.jones2@hp.com, stephen@networkplumber.org, tgraf@suug.ch,
David.Laight@ACULAB.COM
Subject: Re: [Patch net-next] tcp: introduce a per-route knob for quick ack
Date: Wed, 12 Jun 2013 03:02:24 -0700 (PDT) [thread overview]
Message-ID: <20130612.030224.1420421159493116339.davem@davemloft.net> (raw)
In-Reply-To: <1371030955-6740-1-git-send-email-amwang@redhat.com>
From: Cong Wang <amwang@redhat.com>
Date: Wed, 12 Jun 2013 17:55:54 +0800
> According to previous discussion [1], it seems there is no
> reasonable heuristics.
...
> 1. http://marc.info/?t=136507071100004&r=1&w=2
You can't just explain the entire essence of why your patch is
necessary by referring to a URL that might disappear some day.
I'm not even going to look there to review your patch, that
should never be necessary. A patch and it's commit message
should be as self contained as possible.
It is required that you explain, in full detail, and covering
all of the perspectives, the whole issue of ACK behavior in
the commit message.
Otherwise you're making things more difficult for the person who has
to look at this commit in the future.
Thanks.
next prev parent reply other threads:[~2013-06-12 10:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-12 9:55 [Patch net-next] tcp: introduce a per-route knob for quick ack Cong Wang
2013-06-12 9:55 ` [Patch iproute2] add quickack option to ip route Cong Wang
2013-06-12 10:02 ` David Miller [this message]
2013-06-13 1:56 ` [Patch net-next] tcp: introduce a per-route knob for quick ack Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130612.030224.1420421159493116339.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=David.Laight@ACULAB.COM \
--cc=amwang@redhat.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=rick.jones2@hp.com \
--cc=stephen@networkplumber.org \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).