From: David Miller <davem@davemloft.net>
To: nsujir@broadcom.com
Cc: netdev@vger.kernel.org, stable@vger.kernel.org, mchan@broadcom.com
Subject: Re: [PATCH net] tg3: Wait for boot code to finish after power on
Date: Thu, 13 Jun 2013 02:42:35 -0700 (PDT) [thread overview]
Message-ID: <20130613.024235.1657219452701408875.davem@davemloft.net> (raw)
In-Reply-To: <1371060539-27837-1-git-send-email-nsujir@broadcom.com>
From: "Nithin Nayak Sujir" <nsujir@broadcom.com>
Date: Wed, 12 Jun 2013 11:08:59 -0700
> Some systems that don't need wake-on-lan may choose to power down the
> chip on system standby. Upon resume, the power on causes the boot code
> to startup and initialize the hardware. On one new platform, this is
> causing the device to go into a bad state due to a race between the
> driver and boot code, once every several hundred resumes. The same race
> exists on open since we come up from a power on.
>
> This patch adds a wait for boot code signature at the beginning of
> tg3_init_hw() which is common to both cases. If there has not been a
> power-off or the boot code has already completed, the signature will be
> present and poll_fw() returns immediately. Also return immediately if
> the device does not have firmware.
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Nithin Nayak Sujir <nsujir@broadcom.com>
> Signed-off-by: Michael Chan <mchan@broadcom.com>
Applied.
prev parent reply other threads:[~2013-06-13 9:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-12 18:08 [PATCH net] tg3: Wait for boot code to finish after power on Nithin Nayak Sujir
2013-06-13 9:42 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130613.024235.1657219452701408875.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=nsujir@broadcom.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).