From: Eliezer Tamir <eliezer.tamir@linux.intel.com>
To: David Miller <davem@davemloft.net>
Cc: Willem de Bruijn <willemb@google.com>,
Or Kehati <ork@mellanox.com>, Or Gerlitz <or.gerlitz@gmail.com>,
e1000-devel@lists.sourceforge.net, netdev@vger.kernel.org,
HPA <hpa@zytor.com>, Amir Vadai <amirv@mellanox.com>,
linux-kernel@vger.kernel.org, Alex Rosenbaum <alexr@mellanox.com>,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
sockperf-dev@googlegroups.com,
Avner Ben Hanoch <avnerb@mellanox.com>,
Andi Kleen <andi@firstfloor.org>,
Eliezer Tamir <eliezer@tamir.org.il>,
Ben Hutchings <bhutchings@solarflare.com>,
Eric Dumazet <erdnetdev@gmail.com>,
Eilon Greenstien <eilong@broadcom.com>
Subject: [PATCH v3 net-next 1/4] net: convert low latency sockets to sched_clock()
Date: Thu, 13 Jun 2013 17:46:23 +0300 [thread overview]
Message-ID: <20130613144623.4875.2539.stgit@ladj378.jer.intel.com> (raw)
In-Reply-To: <20130613144613.4875.46858.stgit@ladj378.jer.intel.com>
Use sched_clock() instead of get_cycles().
We can use sched_clock() because we don't care much about accuracy.
Remove the dependency on X86_TSC
Signed-off-by: Eliezer Tamir <eliezer.tamir@linux.intel.com>
---
include/net/ll_poll.h | 23 +++++++++++------------
net/Kconfig | 1 -
2 files changed, 11 insertions(+), 13 deletions(-)
diff --git a/include/net/ll_poll.h b/include/net/ll_poll.h
index bc262f8..c75a611 100644
--- a/include/net/ll_poll.h
+++ b/include/net/ll_poll.h
@@ -21,10 +21,6 @@
* e1000-devel Mailing List <e1000-devel@lists.sourceforge.net>
*/
-/*
- * For now this depends on CONFIG_X86_TSC
- */
-
#ifndef _LINUX_NET_LL_POLL_H
#define _LINUX_NET_LL_POLL_H
@@ -41,11 +37,14 @@ extern unsigned long sysctl_net_ll_poll __read_mostly;
#define LL_FLUSH_BUSY -2
/* we don't mind a ~2.5% imprecision */
-#define TSC_MHZ (tsc_khz >> 10)
+#define USECS_TO_NS(us) (us << 10)
-static inline cycles_t ll_end_time(void)
+/* we can use sched_clock() because we don't care much about precision
+ * we only care that the average is bounded
+ */
+static inline u64 ll_end_time(void)
{
- return TSC_MHZ * ACCESS_ONCE(sysctl_net_ll_poll) + get_cycles();
+ return sched_clock() + USECS_TO_NS(ACCESS_ONCE(sysctl_net_ll_poll));
}
static inline bool sk_valid_ll(struct sock *sk)
@@ -54,16 +53,16 @@ static inline bool sk_valid_ll(struct sock *sk)
!need_resched() && !signal_pending(current);
}
-static inline bool can_poll_ll(cycles_t end_time)
+static inline bool can_poll_ll(u64 end_time)
{
- return !time_after((unsigned long)get_cycles(),
+ return !time_after((unsigned long)sched_clock(),
(unsigned long)end_time);
}
static inline bool sk_poll_ll(struct sock *sk, int nonblock)
{
- cycles_t end_time = ll_end_time();
const struct net_device_ops *ops;
+ u64 end_time = ll_end_time();
struct napi_struct *napi;
int rc = false;
@@ -116,7 +115,7 @@ static inline void sk_mark_ll(struct sock *sk, struct sk_buff *skb)
#else /* CONFIG_NET_LL_RX_POLL */
-static inline cycles_t ll_end_time(void)
+static inline u64 ll_end_time(void)
{
return 0;
}
@@ -139,7 +138,7 @@ static inline void sk_mark_ll(struct sock *sk, struct sk_buff *skb)
{
}
-static inline bool can_poll_ll(cycles_t end_time)
+static inline bool can_poll_ll(u64 end_time)
{
return false;
}
diff --git a/net/Kconfig b/net/Kconfig
index d6a9ce6..e591668 100644
--- a/net/Kconfig
+++ b/net/Kconfig
@@ -245,7 +245,6 @@ config NETPRIO_CGROUP
config NET_LL_RX_POLL
bool "Low Latency Receive Poll"
- depends on X86_TSC
default n
---help---
Support Low Latency Receive Queue Poll.
------------------------------------------------------------------------------
This SF.net email is sponsored by Windows:
Build for Windows Store.
http://p.sf.net/sfu/windows-dev2dev
_______________________________________________
E1000-devel mailing list
E1000-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired
next prev parent reply other threads:[~2013-06-13 14:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-13 14:46 [PATCH v3 net-next 0/4] net: low latency sockets follow ups Eliezer Tamir
2013-06-13 14:46 ` Eliezer Tamir [this message]
2013-06-13 14:46 ` [PATCH v3 net-next 2/4] net: remove NET_LL_RX_POLL config menue Eliezer Tamir
2013-06-13 14:46 ` [PATCH v3 net-next 3/4] net: change sysctl_net_ll_poll into an unsigned int Eliezer Tamir
2013-06-13 15:31 ` Eric Dumazet
2013-06-13 15:36 ` Eliezer Tamir
2013-06-13 14:46 ` [PATCH v3 net-next 4/4] net: add socket option for low latency polling Eliezer Tamir
2013-06-13 14:49 ` [PATCH] sockperf: add SO_LL socketop support Eliezer Tamir
2013-06-13 15:03 ` Eliezer Tamir
2013-06-13 15:04 ` [PATCH corrected v2 sockperf] " Eliezer Tamir
2013-06-14 0:43 ` [PATCH v3 net-next 0/4] net: low latency sockets follow ups David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130613144623.4875.2539.stgit@ladj378.jer.intel.com \
--to=eliezer.tamir@linux.intel.com \
--cc=alexr@mellanox.com \
--cc=amirv@mellanox.com \
--cc=andi@firstfloor.org \
--cc=avnerb@mellanox.com \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=e1000-devel@lists.sourceforge.net \
--cc=eilong@broadcom.com \
--cc=eliezer@tamir.org.il \
--cc=erdnetdev@gmail.com \
--cc=hpa@zytor.com \
--cc=jesse.brandeburg@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=or.gerlitz@gmail.com \
--cc=ork@mellanox.com \
--cc=sockperf-dev@googlegroups.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).