From: <Narendra_K@Dell.com>
To: <netdev@vger.kernel.org>
Cc: <ogerlitz@mellanox.com>, <bhutchings@solarflare.com>
Subject: [RFC PATCH net-next] mlx4_en: Do not set dev_id to port number
Date: Fri, 14 Jun 2013 08:06:54 -0700 [thread overview]
Message-ID: <20130614150624.GA1316@fedora-17-guest.blr.amer.dell.com> (raw)
Port number should not be stored in dev_id. 'dev_id' field was
intended to be used to differentiate between multiple devices
which share the same MAC address.
Signed-off-by: Narendra K <narendra_k@dell.com>
---
drivers/net/ethernet/mellanox/mlx4/en_netdev.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/mellanox/mlx4/en_netdev.c b/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
index ade276c..ca618e0 100644
--- a/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
+++ b/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
@@ -2138,7 +2138,6 @@ int mlx4_en_init_netdev(struct mlx4_en_dev *mdev, int port,
netif_set_real_num_rx_queues(dev, prof->rx_ring_num);
SET_NETDEV_DEV(dev, &mdev->dev->pdev->dev);
- dev->dev_id = port - 1;
/*
* Initialize driver private data
--
1.8.0.1
--
With regards,
Narendra K
Linux Engineering
Dell Inc.
next reply other threads:[~2013-06-14 15:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-14 15:06 Narendra_K [this message]
2013-06-14 19:55 ` [RFC PATCH net-next] mlx4_en: Do not set dev_id to port number Or Gerlitz
2013-06-14 20:14 ` Ben Hutchings
2013-06-14 20:18 ` Or Gerlitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130614150624.GA1316@fedora-17-guest.blr.amer.dell.com \
--to=narendra_k@dell.com \
--cc=bhutchings@solarflare.com \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox