From: Olaf Hering <olaf@aepfle.de>
To: Haiyang Zhang <haiyangz@microsoft.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, kys@microsoft.com,
jasowang@redhat.com, linux-kernel@vger.kernel.org,
devel@linuxdriverproject.org
Subject: Re: [PATCH net] hyperv: Fix vlan_proto setting in netvsc_recv_callback()
Date: Fri, 14 Jun 2013 17:28:43 +0200 [thread overview]
Message-ID: <20130614152843.GA11368@aepfle.de> (raw)
In-Reply-To: <1369757756-24572-1-git-send-email-haiyangz@microsoft.com>
On Tue, May 28, Haiyang Zhang wrote:
> Since the recent addition of 8021AD, we need to set the new field vlan_proto in
> sk_buff. Otherwise, it will trigger BUG() call in vlan_proto_idx().
> @@ -284,7 +285,7 @@ int netvsc_recv_callback(struct hv_device *device_obj,
>
> skb->protocol = eth_type_trans(skb, net);
> skb->ip_summed = CHECKSUM_NONE;
> - skb->vlan_tci = packet->vlan_tci;
> + __vlan_hwaccel_put_tag(skb, htons(ETH_P_8021Q), packet->vlan_tci);
Just curious:
Doesnt that change behaviour in the sense that __vlan_hwaccel_put_tag()
now always adds VLAN_TAG_PRESENT to skb->vlan_tci, while before that
change packet->vlan_tci may or may not had this flag?
In other words, should a variant of this patch be backported if it was a
bug not not use __vlan_hwaccel_put_tag right from the start?
Olaf
next prev parent reply other threads:[~2013-06-14 15:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-28 16:15 [PATCH net] hyperv: Fix vlan_proto setting in netvsc_recv_callback() Haiyang Zhang
2013-06-01 0:34 ` David Miller
2013-06-14 15:28 ` Olaf Hering [this message]
2013-06-14 16:24 ` Haiyang Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130614152843.GA11368@aepfle.de \
--to=olaf@aepfle.de \
--cc=davem@davemloft.net \
--cc=devel@linuxdriverproject.org \
--cc=haiyangz@microsoft.com \
--cc=jasowang@redhat.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).