From: David Miller <davem@davemloft.net>
To: nsujir@broadcom.com
Cc: netdev@vger.kernel.org, mchan@broadcom.com
Subject: Re: [PATCH v2 net-next] tg3: Prevent system hang during repeated EEH errors.
Date: Mon, 17 Jun 2013 16:02:43 -0700 (PDT) [thread overview]
Message-ID: <20130617.160243.161622110613940981.davem@davemloft.net> (raw)
In-Reply-To: <1371502045-8044-1-git-send-email-nsujir@broadcom.com>
From: "Nithin Nayak Sujir" <nsujir@broadcom.com>
Date: Mon, 17 Jun 2013 13:47:25 -0700
> From: Michael Chan <mchan@broadcom.com>
>
> The current tg3 code assumes the pci_error_handlers to be always called
> in sequence. In particular, during ->error_detected(), NAPI is disabled
> and the device is shutdown. The device is later reset and NAPI
> re-enabled in ->slot_reset() and ->resume().
>
> In EEH, if more than 6 errors are detected in a hour, only
> ->error_detected() will be called. This will leave the driver in an
> inconsistent state as NAPI is disabled but netif_running state is still
> true. When the device is later closed, we'll try to disable NAPI again
> and it will loop forever.
>
> We fix this by closing the device if we encounter any error conditions
> during the normal sequence of the pci_error_handlers.
>
> v2: Remove the changes in tg3_io_resume() based on Benjamin Poirier's
> feedback.
>
> Signed-off-by: Michael Chan <mchan@broadcom.com>
> Signed-off-by: Nithin Nayak Sujir <nsujir@broadcom.com>
Applied, thanks.
prev parent reply other threads:[~2013-06-17 23:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-17 20:47 [PATCH v2 net-next] tg3: Prevent system hang during repeated EEH errors Nithin Nayak Sujir
2013-06-17 23:02 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130617.160243.161622110613940981.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=nsujir@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).