* [PATCH] bridge: fix switched interval for MLD Query types
@ 2013-06-16 21:20 Linus Lüssing
2013-06-18 0:11 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Linus Lüssing @ 2013-06-16 21:20 UTC (permalink / raw)
To: bridge
Cc: Stephen Hemminger, netdev, Linus Lüssing, David S. Miller,
linux-kernel
General Queries (the one with the Multicast Address field
set to zero / '::') are supposed to have a Maximum Response Delay
of [Query Response Interval], while for Multicast-Address-Specific
Queries it is [Last Listener Query Interval] - not the other way
round. (see RFC2710, section 7.3+7.8)
Signed-off-by: Linus Lüssing <linus.luessing@web.de>
---
net/bridge/br_multicast.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/net/bridge/br_multicast.c b/net/bridge/br_multicast.c
index 81f2389..d6448e3 100644
--- a/net/bridge/br_multicast.c
+++ b/net/bridge/br_multicast.c
@@ -465,8 +465,9 @@ static struct sk_buff *br_ip6_multicast_alloc_query(struct net_bridge *br,
skb_set_transport_header(skb, skb->len);
mldq = (struct mld_msg *) icmp6_hdr(skb);
- interval = ipv6_addr_any(group) ? br->multicast_last_member_interval :
- br->multicast_query_response_interval;
+ interval = ipv6_addr_any(group) ?
+ br->multicast_query_response_interval :
+ br->multicast_last_member_interval;
mldq->mld_type = ICMPV6_MGM_QUERY;
mldq->mld_code = 0;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] bridge: fix switched interval for MLD Query types
2013-06-16 21:20 [PATCH] bridge: fix switched interval for MLD Query types Linus Lüssing
@ 2013-06-18 0:11 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2013-06-18 0:11 UTC (permalink / raw)
To: linus.luessing; +Cc: stephen, netdev, bridge, linux-kernel
From: Linus Lüssing <linus.luessing@web.de>
Date: Sun, 16 Jun 2013 23:20:34 +0200
> General Queries (the one with the Multicast Address field
> set to zero / '::') are supposed to have a Maximum Response Delay
> of [Query Response Interval], while for Multicast-Address-Specific
> Queries it is [Last Listener Query Interval] - not the other way
> round. (see RFC2710, section 7.3+7.8)
>
> Signed-off-by: Linus Lüssing <linus.luessing@web.de>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-06-18 0:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-16 21:20 [PATCH] bridge: fix switched interval for MLD Query types Linus Lüssing
2013-06-18 0:11 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).