netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net-next 1/5] net, atm/ambassader: convert skb->tail into skb_tail_pointer(skb)
@ 2013-06-14  8:58 Isaku Yamahata
  2013-06-14  8:58 ` [PATCH net-next 2/5] net, scsi/csgb4i: convert skb->transport_header into skb_transport_header(skb) Isaku Yamahata
                   ` (4 more replies)
  0 siblings, 5 replies; 16+ messages in thread
From: Isaku Yamahata @ 2013-06-14  8:58 UTC (permalink / raw)
  To: netdev; +Cc: yamahata, Simon Horman, Chas Williams

The change set of 27a884dc, "[SK_BUFF]: Convert skb->tail to sk_buff_data_t"
converted skb->tail from pointer into sk_buff_data_t. It missed skb->tail
in drivers/atm/ambassador.c.
This patch converts skb->tail into skb_tail_pointer(skb).

Found by inspection. Compile tested only.

Cc: Simon Horman <horms@verge.net.au>
Cc: Chas Williams <chas@cmf.nrl.navy.mil>
Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>
---
 drivers/atm/ambassador.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/atm/ambassador.c b/drivers/atm/ambassador.c
index 77a7480..62a7607 100644
--- a/drivers/atm/ambassador.c
+++ b/drivers/atm/ambassador.c
@@ -1403,7 +1403,7 @@ static void amb_free_rx_skb (struct atm_vcc * atm_vcc, struct sk_buff * skb) {
   rx.host_address = cpu_to_be32 (virt_to_bus (skb->data));
   
   skb->data = skb->head;
-  skb->tail = skb->head;
+  skb_reset_tail_pointer(skb);
   skb->len = 0;
   
   if (!rx_give (dev, &rx, pool)) {
-- 
1.7.10.4

^ permalink raw reply related	[flat|nested] 16+ messages in thread

* [PATCH net-next 2/5] net, scsi/csgb4i: convert skb->transport_header into skb_transport_header(skb)
  2013-06-14  8:58 [PATCH net-next 1/5] net, atm/ambassader: convert skb->tail into skb_tail_pointer(skb) Isaku Yamahata
@ 2013-06-14  8:58 ` Isaku Yamahata
  2013-06-17  2:04   ` Simon Horman
  2013-06-14  8:58 ` [PATCH net-next 3/5] mv643xx_eth.c: convert skb->end into skb_end_poitner(skb) Isaku Yamahata
                   ` (3 subsequent siblings)
  4 siblings, 1 reply; 16+ messages in thread
From: Isaku Yamahata @ 2013-06-14  8:58 UTC (permalink / raw)
  To: netdev; +Cc: yamahata, Simon Horman, Li RongQing, linux-scsi

The change set of 1a37e412, "net: Use 16bits for *_headers fields
of struct skbuff" converted from sk_buff_data_t into 16bit integer.
So skb->tail needs to be converted to skb_tail_pointer(skb).

Found by inspection. Compile tested only.

Cc: Simon Horman <horms@verge.net.au>
Cc: Li RongQing <roy.qing.li@gmail.com>
Cc: linux-scsi@vger.kernel.org
Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>
---
 drivers/scsi/cxgbi/cxgb4i/cxgb4i.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/cxgbi/cxgb4i/cxgb4i.c b/drivers/scsi/cxgbi/cxgb4i/cxgb4i.c
index 3fecf35..9138d4e 100644
--- a/drivers/scsi/cxgbi/cxgb4i/cxgb4i.c
+++ b/drivers/scsi/cxgbi/cxgb4i/cxgb4i.c
@@ -358,7 +358,7 @@ static inline unsigned int calc_tx_flits_ofld(const struct sk_buff *skb)
 		return DIV_ROUND_UP(skb->len, 8);
 	flits = skb_transport_offset(skb) / 8;
 	cnt = skb_shinfo(skb)->nr_frags;
-	if (skb->tail != skb->transport_header)
+	if (skb_tail_pointer(skb) != skb_transport_header(skb))
 		cnt++;
 	return flits + sgl_len(cnt);
 }
-- 
1.7.10.4


^ permalink raw reply related	[flat|nested] 16+ messages in thread

* [PATCH net-next 3/5] mv643xx_eth.c: convert skb->end into skb_end_poitner(skb)
  2013-06-14  8:58 [PATCH net-next 1/5] net, atm/ambassader: convert skb->tail into skb_tail_pointer(skb) Isaku Yamahata
  2013-06-14  8:58 ` [PATCH net-next 2/5] net, scsi/csgb4i: convert skb->transport_header into skb_transport_header(skb) Isaku Yamahata
@ 2013-06-14  8:58 ` Isaku Yamahata
  2013-06-17  2:02   ` Simon Horman
  2013-06-14  8:58 ` [PATCH net-next 4/5] pxa168_eth: convert skb->end into skb_end_pointer(skb) Isaku Yamahata
                   ` (2 subsequent siblings)
  4 siblings, 1 reply; 16+ messages in thread
From: Isaku Yamahata @ 2013-06-14  8:58 UTC (permalink / raw)
  To: netdev; +Cc: yamahata, Simon Horman, Lennert Buytenhek

The change set of 4305b541 "[SK_BUFF]: Convert skb->end to sk_buff_data_t"
converted skb->end from pointer to sk_buff_data_t.
The pointed value should be accessed via skb_end_pointer().

Since arm or ppc arch doesn't define NET_SKBUFF_DATA_USES_OFFSET,
skb->end is effectively pointer. So it doesn't cause a real problem.
But this patch is good for consistency.

Found by inspection. Compile test only.

Cc: Simon Horman <horms@verge.net.au>
Cc: Lennert Buytenhek <buytenh@wantstofly.org>
Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>
---
 drivers/net/ethernet/marvell/mv643xx_eth.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/marvell/mv643xx_eth.c b/drivers/net/ethernet/marvell/mv643xx_eth.c
index c7f9fb3..510d506 100644
--- a/drivers/net/ethernet/marvell/mv643xx_eth.c
+++ b/drivers/net/ethernet/marvell/mv643xx_eth.c
@@ -621,7 +621,7 @@ static int rxq_refill(struct rx_queue *rxq, int budget)
 
 		rx_desc = rxq->rx_desc_area + rx;
 
-		size = skb->end - skb->data;
+		size = skb_end_pointer(skb) - skb->data;
 		rx_desc->buf_ptr = dma_map_single(mp->dev->dev.parent,
 						  skb->data, size,
 						  DMA_FROM_DEVICE);
-- 
1.7.10.4

^ permalink raw reply related	[flat|nested] 16+ messages in thread

* [PATCH net-next 4/5] pxa168_eth: convert skb->end into skb_end_pointer(skb)
  2013-06-14  8:58 [PATCH net-next 1/5] net, atm/ambassader: convert skb->tail into skb_tail_pointer(skb) Isaku Yamahata
  2013-06-14  8:58 ` [PATCH net-next 2/5] net, scsi/csgb4i: convert skb->transport_header into skb_transport_header(skb) Isaku Yamahata
  2013-06-14  8:58 ` [PATCH net-next 3/5] mv643xx_eth.c: convert skb->end into skb_end_poitner(skb) Isaku Yamahata
@ 2013-06-14  8:58 ` Isaku Yamahata
  2013-06-17  2:01   ` Simon Horman
  2013-06-14  8:58 ` [PATCH net-next 5/5] staging/rtl8192u: convert skb->tail into skb_tail_pointer(skb) Isaku Yamahata
  2013-06-17  2:01 ` [PATCH net-next 1/5] net, atm/ambassader: " Simon Horman
  4 siblings, 1 reply; 16+ messages in thread
From: Isaku Yamahata @ 2013-06-14  8:58 UTC (permalink / raw)
  To: netdev; +Cc: yamahata, Simon Horman

The change set of 4305b541, "[SK_BUFF]: Convert skb->end to sk_buff_data_t"
converted skb->end from pointer type to sk_buff_data_t.
The pointed value should be accessed via skb_end_pointer().

Since arm arch doesn't define NET_SKBUFF_DATA_USES_OFFSET,
skb->end is effectively pointer. So it doesn't cause a real problem.
But this patch is good for consistency.

Found by inspection. Compile tested only.

Cc: Simon Horman <horms@verge.net.au>
Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>
---
 drivers/net/ethernet/marvell/pxa168_eth.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/marvell/pxa168_eth.c b/drivers/net/ethernet/marvell/pxa168_eth.c
index 2602cf7..ec20508 100644
--- a/drivers/net/ethernet/marvell/pxa168_eth.c
+++ b/drivers/net/ethernet/marvell/pxa168_eth.c
@@ -357,7 +357,7 @@ static void rxq_refill(struct net_device *dev)
 		/* Get 'used' Rx descriptor */
 		used_rx_desc = pep->rx_used_desc_q;
 		p_used_rx_desc = &pep->p_rx_desc_area[used_rx_desc];
-		size = skb->end - skb->data;
+		size = skb_end_pointer(skb) - skb->data;
 		p_used_rx_desc->buf_ptr = dma_map_single(NULL,
 							 skb->data,
 							 size,
-- 
1.7.10.4

^ permalink raw reply related	[flat|nested] 16+ messages in thread

* [PATCH net-next 5/5] staging/rtl8192u: convert skb->tail into skb_tail_pointer(skb)
  2013-06-14  8:58 [PATCH net-next 1/5] net, atm/ambassader: convert skb->tail into skb_tail_pointer(skb) Isaku Yamahata
                   ` (2 preceding siblings ...)
  2013-06-14  8:58 ` [PATCH net-next 4/5] pxa168_eth: convert skb->end into skb_end_pointer(skb) Isaku Yamahata
@ 2013-06-14  8:58 ` Isaku Yamahata
  2013-06-17  2:03   ` Simon Horman
  2013-06-17 22:45   ` Greg Kroah-Hartman
  2013-06-17  2:01 ` [PATCH net-next 1/5] net, atm/ambassader: " Simon Horman
  4 siblings, 2 replies; 16+ messages in thread
From: Isaku Yamahata @ 2013-06-14  8:58 UTC (permalink / raw)
  To: netdev; +Cc: yamahata, Simon Horman, Greg Kroah-Hartman, devel

The change set of 7a884dc "[SK_BUFF]: Convert skb->tail to sk_buff_data_t"
converted skb->tail from pointer into sk_buff_data_t.
Thus skb->tail is not always pointer, the area pointed by skb->tail
should be accessed via skb_tail_pointer().

Found by inspection. Compile tested only.

Cc: Simon Horman <horms@verge.net.au>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: devel@driverdev.osuosl.org
Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>
---
 drivers/staging/rtl8192u/r8192U_core.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r8192U_core.c
index 71f5cde..a18430e 100644
--- a/drivers/staging/rtl8192u/r8192U_core.c
+++ b/drivers/staging/rtl8192u/r8192U_core.c
@@ -1271,8 +1271,8 @@ struct sk_buff *DrvAggr_Aggregation(struct net_device *dev, struct ieee80211_drv
 		/* Subframe drv Tx descriptor and firmware info setting */
 		skb = pSendList->tx_agg_frames[i];
 		tcb_desc = (cb_desc *)(skb->cb + MAX_DEV_ADDR_SIZE);
-		tx_agg_desc = (tx_desc_819x_usb_aggr_subframe *)agg_skb->tail;
-		tx_fwinfo = (tx_fwinfo_819x_usb *)(agg_skb->tail + sizeof(tx_desc_819x_usb_aggr_subframe));
+		tx_agg_desc = (tx_desc_819x_usb_aggr_subframe *)skb_tail_pointer(agg_skb);
+		tx_fwinfo = (tx_fwinfo_819x_usb *)(skb_tail_pointer(agg_skb) + sizeof(tx_desc_819x_usb_aggr_subframe));
 
 		memset(tx_fwinfo,0,sizeof(tx_fwinfo_819x_usb));
 		/* DWORD 0 */
-- 
1.7.10.4

^ permalink raw reply related	[flat|nested] 16+ messages in thread

* Re: [PATCH net-next 1/5] net, atm/ambassader: convert skb->tail into skb_tail_pointer(skb)
  2013-06-14  8:58 [PATCH net-next 1/5] net, atm/ambassader: convert skb->tail into skb_tail_pointer(skb) Isaku Yamahata
                   ` (3 preceding siblings ...)
  2013-06-14  8:58 ` [PATCH net-next 5/5] staging/rtl8192u: convert skb->tail into skb_tail_pointer(skb) Isaku Yamahata
@ 2013-06-17  2:01 ` Simon Horman
  2013-06-18  0:13   ` David Miller
  4 siblings, 1 reply; 16+ messages in thread
From: Simon Horman @ 2013-06-17  2:01 UTC (permalink / raw)
  To: Isaku Yamahata; +Cc: netdev, Chas Williams

On Fri, Jun 14, 2013 at 05:58:31PM +0900, Isaku Yamahata wrote:
> The change set of 27a884dc, "[SK_BUFF]: Convert skb->tail to sk_buff_data_t"
> converted skb->tail from pointer into sk_buff_data_t. It missed skb->tail
> in drivers/atm/ambassador.c.
> This patch converts skb->tail into skb_tail_pointer(skb).
> 
> Found by inspection. Compile tested only.
> 
> Cc: Simon Horman <horms@verge.net.au>
> Cc: Chas Williams <chas@cmf.nrl.navy.mil>
> Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>

Reviewed-by: Simon Horman <horms@verge.net.au>

> ---
>  drivers/atm/ambassador.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/atm/ambassador.c b/drivers/atm/ambassador.c
> index 77a7480..62a7607 100644
> --- a/drivers/atm/ambassador.c
> +++ b/drivers/atm/ambassador.c
> @@ -1403,7 +1403,7 @@ static void amb_free_rx_skb (struct atm_vcc * atm_vcc, struct sk_buff * skb) {
>    rx.host_address = cpu_to_be32 (virt_to_bus (skb->data));
>    
>    skb->data = skb->head;
> -  skb->tail = skb->head;
> +  skb_reset_tail_pointer(skb);
>    skb->len = 0;
>    
>    if (!rx_give (dev, &rx, pool)) {
> -- 
> 1.7.10.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH net-next 4/5] pxa168_eth: convert skb->end into skb_end_pointer(skb)
  2013-06-14  8:58 ` [PATCH net-next 4/5] pxa168_eth: convert skb->end into skb_end_pointer(skb) Isaku Yamahata
@ 2013-06-17  2:01   ` Simon Horman
  2013-06-18  0:13     ` David Miller
  0 siblings, 1 reply; 16+ messages in thread
From: Simon Horman @ 2013-06-17  2:01 UTC (permalink / raw)
  To: Isaku Yamahata; +Cc: netdev

On Fri, Jun 14, 2013 at 05:58:34PM +0900, Isaku Yamahata wrote:
> The change set of 4305b541, "[SK_BUFF]: Convert skb->end to sk_buff_data_t"
> converted skb->end from pointer type to sk_buff_data_t.
> The pointed value should be accessed via skb_end_pointer().
> 
> Since arm arch doesn't define NET_SKBUFF_DATA_USES_OFFSET,
> skb->end is effectively pointer. So it doesn't cause a real problem.
> But this patch is good for consistency.
> 
> Found by inspection. Compile tested only.
> 
> Cc: Simon Horman <horms@verge.net.au>
> Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>

Reviewed-by: Simon Horman <horms@verge.net.au>

> ---
>  drivers/net/ethernet/marvell/pxa168_eth.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/marvell/pxa168_eth.c b/drivers/net/ethernet/marvell/pxa168_eth.c
> index 2602cf7..ec20508 100644
> --- a/drivers/net/ethernet/marvell/pxa168_eth.c
> +++ b/drivers/net/ethernet/marvell/pxa168_eth.c
> @@ -357,7 +357,7 @@ static void rxq_refill(struct net_device *dev)
>  		/* Get 'used' Rx descriptor */
>  		used_rx_desc = pep->rx_used_desc_q;
>  		p_used_rx_desc = &pep->p_rx_desc_area[used_rx_desc];
> -		size = skb->end - skb->data;
> +		size = skb_end_pointer(skb) - skb->data;
>  		p_used_rx_desc->buf_ptr = dma_map_single(NULL,
>  							 skb->data,
>  							 size,
> -- 
> 1.7.10.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH net-next 3/5] mv643xx_eth.c: convert skb->end into skb_end_poitner(skb)
  2013-06-14  8:58 ` [PATCH net-next 3/5] mv643xx_eth.c: convert skb->end into skb_end_poitner(skb) Isaku Yamahata
@ 2013-06-17  2:02   ` Simon Horman
  2013-06-18  0:13     ` David Miller
  0 siblings, 1 reply; 16+ messages in thread
From: Simon Horman @ 2013-06-17  2:02 UTC (permalink / raw)
  To: Isaku Yamahata; +Cc: netdev, Lennert Buytenhek

On Fri, Jun 14, 2013 at 05:58:33PM +0900, Isaku Yamahata wrote:
> The change set of 4305b541 "[SK_BUFF]: Convert skb->end to sk_buff_data_t"
> converted skb->end from pointer to sk_buff_data_t.
> The pointed value should be accessed via skb_end_pointer().
> 
> Since arm or ppc arch doesn't define NET_SKBUFF_DATA_USES_OFFSET,
> skb->end is effectively pointer. So it doesn't cause a real problem.
> But this patch is good for consistency.
> 
> Found by inspection. Compile test only.
> 
> Cc: Simon Horman <horms@verge.net.au>
> Cc: Lennert Buytenhek <buytenh@wantstofly.org>
> Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>

Reviewed-by: Simon Horman <horms@verge.net.au>

> ---
>  drivers/net/ethernet/marvell/mv643xx_eth.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/marvell/mv643xx_eth.c b/drivers/net/ethernet/marvell/mv643xx_eth.c
> index c7f9fb3..510d506 100644
> --- a/drivers/net/ethernet/marvell/mv643xx_eth.c
> +++ b/drivers/net/ethernet/marvell/mv643xx_eth.c
> @@ -621,7 +621,7 @@ static int rxq_refill(struct rx_queue *rxq, int budget)
>  
>  		rx_desc = rxq->rx_desc_area + rx;
>  
> -		size = skb->end - skb->data;
> +		size = skb_end_pointer(skb) - skb->data;
>  		rx_desc->buf_ptr = dma_map_single(mp->dev->dev.parent,
>  						  skb->data, size,
>  						  DMA_FROM_DEVICE);
> -- 
> 1.7.10.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH net-next 5/5] staging/rtl8192u: convert skb->tail into skb_tail_pointer(skb)
  2013-06-14  8:58 ` [PATCH net-next 5/5] staging/rtl8192u: convert skb->tail into skb_tail_pointer(skb) Isaku Yamahata
@ 2013-06-17  2:03   ` Simon Horman
  2013-06-18  0:13     ` David Miller
  2013-06-17 22:45   ` Greg Kroah-Hartman
  1 sibling, 1 reply; 16+ messages in thread
From: Simon Horman @ 2013-06-17  2:03 UTC (permalink / raw)
  To: Isaku Yamahata; +Cc: netdev, Greg Kroah-Hartman, devel

On Fri, Jun 14, 2013 at 05:58:35PM +0900, Isaku Yamahata wrote:
> The change set of 7a884dc "[SK_BUFF]: Convert skb->tail to sk_buff_data_t"
> converted skb->tail from pointer into sk_buff_data_t.
> Thus skb->tail is not always pointer, the area pointed by skb->tail
> should be accessed via skb_tail_pointer().
> 
> Found by inspection. Compile tested only.
> 
> Cc: Simon Horman <horms@verge.net.au>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: devel@driverdev.osuosl.org
> Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>

Reviewed-by: Simon Horman <horms@verge.net.au>

> ---
>  drivers/staging/rtl8192u/r8192U_core.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r8192U_core.c
> index 71f5cde..a18430e 100644
> --- a/drivers/staging/rtl8192u/r8192U_core.c
> +++ b/drivers/staging/rtl8192u/r8192U_core.c
> @@ -1271,8 +1271,8 @@ struct sk_buff *DrvAggr_Aggregation(struct net_device *dev, struct ieee80211_drv
>  		/* Subframe drv Tx descriptor and firmware info setting */
>  		skb = pSendList->tx_agg_frames[i];
>  		tcb_desc = (cb_desc *)(skb->cb + MAX_DEV_ADDR_SIZE);
> -		tx_agg_desc = (tx_desc_819x_usb_aggr_subframe *)agg_skb->tail;
> -		tx_fwinfo = (tx_fwinfo_819x_usb *)(agg_skb->tail + sizeof(tx_desc_819x_usb_aggr_subframe));
> +		tx_agg_desc = (tx_desc_819x_usb_aggr_subframe *)skb_tail_pointer(agg_skb);
> +		tx_fwinfo = (tx_fwinfo_819x_usb *)(skb_tail_pointer(agg_skb) + sizeof(tx_desc_819x_usb_aggr_subframe));
>  
>  		memset(tx_fwinfo,0,sizeof(tx_fwinfo_819x_usb));
>  		/* DWORD 0 */
> -- 
> 1.7.10.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH net-next 2/5] net, scsi/csgb4i: convert skb->transport_header into skb_transport_header(skb)
  2013-06-14  8:58 ` [PATCH net-next 2/5] net, scsi/csgb4i: convert skb->transport_header into skb_transport_header(skb) Isaku Yamahata
@ 2013-06-17  2:04   ` Simon Horman
  2013-06-18  0:13     ` David Miller
  0 siblings, 1 reply; 16+ messages in thread
From: Simon Horman @ 2013-06-17  2:04 UTC (permalink / raw)
  To: Isaku Yamahata; +Cc: netdev, Li RongQing, linux-scsi

On Fri, Jun 14, 2013 at 05:58:32PM +0900, Isaku Yamahata wrote:
> The change set of 1a37e412, "net: Use 16bits for *_headers fields
> of struct skbuff" converted from sk_buff_data_t into 16bit integer.
> So skb->tail needs to be converted to skb_tail_pointer(skb).
> 
> Found by inspection. Compile tested only.
> 
> Cc: Simon Horman <horms@verge.net.au>
> Cc: Li RongQing <roy.qing.li@gmail.com>
> Cc: linux-scsi@vger.kernel.org
> Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>

Acked-by: Simon Horman <horms@verge.net.au>

> ---
>  drivers/scsi/cxgbi/cxgb4i/cxgb4i.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/cxgbi/cxgb4i/cxgb4i.c b/drivers/scsi/cxgbi/cxgb4i/cxgb4i.c
> index 3fecf35..9138d4e 100644
> --- a/drivers/scsi/cxgbi/cxgb4i/cxgb4i.c
> +++ b/drivers/scsi/cxgbi/cxgb4i/cxgb4i.c
> @@ -358,7 +358,7 @@ static inline unsigned int calc_tx_flits_ofld(const struct sk_buff *skb)
>  		return DIV_ROUND_UP(skb->len, 8);
>  	flits = skb_transport_offset(skb) / 8;
>  	cnt = skb_shinfo(skb)->nr_frags;
> -	if (skb->tail != skb->transport_header)
> +	if (skb_tail_pointer(skb) != skb_transport_header(skb))
>  		cnt++;
>  	return flits + sgl_len(cnt);
>  }
> -- 
> 1.7.10.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH net-next 5/5] staging/rtl8192u: convert skb->tail into skb_tail_pointer(skb)
  2013-06-14  8:58 ` [PATCH net-next 5/5] staging/rtl8192u: convert skb->tail into skb_tail_pointer(skb) Isaku Yamahata
  2013-06-17  2:03   ` Simon Horman
@ 2013-06-17 22:45   ` Greg Kroah-Hartman
  1 sibling, 0 replies; 16+ messages in thread
From: Greg Kroah-Hartman @ 2013-06-17 22:45 UTC (permalink / raw)
  To: Isaku Yamahata; +Cc: netdev, Simon Horman, devel

On Fri, Jun 14, 2013 at 05:58:35PM +0900, Isaku Yamahata wrote:
> The change set of 7a884dc "[SK_BUFF]: Convert skb->tail to sk_buff_data_t"
> converted skb->tail from pointer into sk_buff_data_t.
> Thus skb->tail is not always pointer, the area pointed by skb->tail
> should be accessed via skb_tail_pointer().
> 
> Found by inspection. Compile tested only.

Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH net-next 1/5] net, atm/ambassader: convert skb->tail into skb_tail_pointer(skb)
  2013-06-17  2:01 ` [PATCH net-next 1/5] net, atm/ambassader: " Simon Horman
@ 2013-06-18  0:13   ` David Miller
  0 siblings, 0 replies; 16+ messages in thread
From: David Miller @ 2013-06-18  0:13 UTC (permalink / raw)
  To: horms; +Cc: yamahata, netdev, chas

From: Simon Horman <horms@verge.net.au>
Date: Mon, 17 Jun 2013 11:01:09 +0900

> On Fri, Jun 14, 2013 at 05:58:31PM +0900, Isaku Yamahata wrote:
>> The change set of 27a884dc, "[SK_BUFF]: Convert skb->tail to sk_buff_data_t"
>> converted skb->tail from pointer into sk_buff_data_t. It missed skb->tail
>> in drivers/atm/ambassador.c.
>> This patch converts skb->tail into skb_tail_pointer(skb).
>> 
>> Found by inspection. Compile tested only.
>> 
>> Cc: Simon Horman <horms@verge.net.au>
>> Cc: Chas Williams <chas@cmf.nrl.navy.mil>
>> Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>
> 
> Reviewed-by: Simon Horman <horms@verge.net.au>

Applied.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH net-next 2/5] net, scsi/csgb4i: convert skb->transport_header into skb_transport_header(skb)
  2013-06-17  2:04   ` Simon Horman
@ 2013-06-18  0:13     ` David Miller
  0 siblings, 0 replies; 16+ messages in thread
From: David Miller @ 2013-06-18  0:13 UTC (permalink / raw)
  To: horms; +Cc: yamahata, netdev, roy.qing.li, linux-scsi

From: Simon Horman <horms@verge.net.au>
Date: Mon, 17 Jun 2013 11:04:11 +0900

> On Fri, Jun 14, 2013 at 05:58:32PM +0900, Isaku Yamahata wrote:
>> The change set of 1a37e412, "net: Use 16bits for *_headers fields
>> of struct skbuff" converted from sk_buff_data_t into 16bit integer.
>> So skb->tail needs to be converted to skb_tail_pointer(skb).
>> 
>> Found by inspection. Compile tested only.
>> 
>> Cc: Simon Horman <horms@verge.net.au>
>> Cc: Li RongQing <roy.qing.li@gmail.com>
>> Cc: linux-scsi@vger.kernel.org
>> Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>
> 
> Acked-by: Simon Horman <horms@verge.net.au>

Applied.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH net-next 3/5] mv643xx_eth.c: convert skb->end into skb_end_poitner(skb)
  2013-06-17  2:02   ` Simon Horman
@ 2013-06-18  0:13     ` David Miller
  0 siblings, 0 replies; 16+ messages in thread
From: David Miller @ 2013-06-18  0:13 UTC (permalink / raw)
  To: horms; +Cc: yamahata, netdev, buytenh

From: Simon Horman <horms@verge.net.au>
Date: Mon, 17 Jun 2013 11:02:18 +0900

> On Fri, Jun 14, 2013 at 05:58:33PM +0900, Isaku Yamahata wrote:
>> The change set of 4305b541 "[SK_BUFF]: Convert skb->end to sk_buff_data_t"
>> converted skb->end from pointer to sk_buff_data_t.
>> The pointed value should be accessed via skb_end_pointer().
>> 
>> Since arm or ppc arch doesn't define NET_SKBUFF_DATA_USES_OFFSET,
>> skb->end is effectively pointer. So it doesn't cause a real problem.
>> But this patch is good for consistency.
>> 
>> Found by inspection. Compile test only.
>> 
>> Cc: Simon Horman <horms@verge.net.au>
>> Cc: Lennert Buytenhek <buytenh@wantstofly.org>
>> Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>
> 
> Reviewed-by: Simon Horman <horms@verge.net.au>

Applied.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH net-next 4/5] pxa168_eth: convert skb->end into skb_end_pointer(skb)
  2013-06-17  2:01   ` Simon Horman
@ 2013-06-18  0:13     ` David Miller
  0 siblings, 0 replies; 16+ messages in thread
From: David Miller @ 2013-06-18  0:13 UTC (permalink / raw)
  To: horms; +Cc: yamahata, netdev

From: Simon Horman <horms@verge.net.au>
Date: Mon, 17 Jun 2013 11:01:50 +0900

> On Fri, Jun 14, 2013 at 05:58:34PM +0900, Isaku Yamahata wrote:
>> The change set of 4305b541, "[SK_BUFF]: Convert skb->end to sk_buff_data_t"
>> converted skb->end from pointer type to sk_buff_data_t.
>> The pointed value should be accessed via skb_end_pointer().
>> 
>> Since arm arch doesn't define NET_SKBUFF_DATA_USES_OFFSET,
>> skb->end is effectively pointer. So it doesn't cause a real problem.
>> But this patch is good for consistency.
>> 
>> Found by inspection. Compile tested only.
>> 
>> Cc: Simon Horman <horms@verge.net.au>
>> Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>
> 
> Reviewed-by: Simon Horman <horms@verge.net.au>

Applied.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH net-next 5/5] staging/rtl8192u: convert skb->tail into skb_tail_pointer(skb)
  2013-06-17  2:03   ` Simon Horman
@ 2013-06-18  0:13     ` David Miller
  0 siblings, 0 replies; 16+ messages in thread
From: David Miller @ 2013-06-18  0:13 UTC (permalink / raw)
  To: horms; +Cc: yamahata, netdev, gregkh, devel

From: Simon Horman <horms@verge.net.au>
Date: Mon, 17 Jun 2013 11:03:05 +0900

> On Fri, Jun 14, 2013 at 05:58:35PM +0900, Isaku Yamahata wrote:
>> The change set of 7a884dc "[SK_BUFF]: Convert skb->tail to sk_buff_data_t"
>> converted skb->tail from pointer into sk_buff_data_t.
>> Thus skb->tail is not always pointer, the area pointed by skb->tail
>> should be accessed via skb_tail_pointer().
>> 
>> Found by inspection. Compile tested only.
>> 
>> Cc: Simon Horman <horms@verge.net.au>
>> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>> Cc: devel@driverdev.osuosl.org
>> Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>
> 
> Reviewed-by: Simon Horman <horms@verge.net.au>

Applied.

^ permalink raw reply	[flat|nested] 16+ messages in thread

end of thread, other threads:[~2013-06-18  0:13 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-14  8:58 [PATCH net-next 1/5] net, atm/ambassader: convert skb->tail into skb_tail_pointer(skb) Isaku Yamahata
2013-06-14  8:58 ` [PATCH net-next 2/5] net, scsi/csgb4i: convert skb->transport_header into skb_transport_header(skb) Isaku Yamahata
2013-06-17  2:04   ` Simon Horman
2013-06-18  0:13     ` David Miller
2013-06-14  8:58 ` [PATCH net-next 3/5] mv643xx_eth.c: convert skb->end into skb_end_poitner(skb) Isaku Yamahata
2013-06-17  2:02   ` Simon Horman
2013-06-18  0:13     ` David Miller
2013-06-14  8:58 ` [PATCH net-next 4/5] pxa168_eth: convert skb->end into skb_end_pointer(skb) Isaku Yamahata
2013-06-17  2:01   ` Simon Horman
2013-06-18  0:13     ` David Miller
2013-06-14  8:58 ` [PATCH net-next 5/5] staging/rtl8192u: convert skb->tail into skb_tail_pointer(skb) Isaku Yamahata
2013-06-17  2:03   ` Simon Horman
2013-06-18  0:13     ` David Miller
2013-06-17 22:45   ` Greg Kroah-Hartman
2013-06-17  2:01 ` [PATCH net-next 1/5] net, atm/ambassader: " Simon Horman
2013-06-18  0:13   ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).