From: Benjamin Poirier <benjamin.poirier@gmail.com>
To: Nithin Nayak Sujir <nsujir@broadcom.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
Michael Chan <mchan@broadcom.com>
Subject: Re: [PATCH net-next] tg3: Prevent system hang during repeated EEH errors.
Date: Mon, 17 Jun 2013 14:28:11 -0400 [thread overview]
Message-ID: <20130617182811.GA12442@d2.synalogic.ca> (raw)
In-Reply-To: <1371244506-18969-1-git-send-email-nsujir@broadcom.com>
On 2013/06/14 14:15, Nithin Nayak Sujir wrote:
[...]
> @@ -17796,6 +17799,10 @@ static pci_ers_result_t tg3_io_slot_reset(struct pci_dev *pdev)
> rc = PCI_ERS_RESULT_RECOVERED;
>
> done:
> + if (rc != PCI_ERS_RESULT_RECOVERED && netif_running(netdev)) {
> + tg3_napi_enable(tp);
> + dev_close(netdev);
> + }
> rtnl_unlock();
>
> return rc;
> @@ -17826,6 +17833,8 @@ static void tg3_io_resume(struct pci_dev *pdev)
> if (err) {
> tg3_full_unlock(tp);
> netdev_err(netdev, "Cannot restart hardware after reset.\n");
> + tg3_napi_enable(tp);
> + dev_close(netdev);
> goto done;
> }
Are these two hunks needed?
1) These functions do not call tg3_netif_stop() or tg3_napi_disable()
2) an error in tg3_io_resume() does not trigger device removal in
handle_eeh_events(). In fact the ->resume callback has no return value.
>
> --
> 1.8.1.4
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-06-17 18:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-14 21:15 [PATCH net-next] tg3: Prevent system hang during repeated EEH errors Nithin Nayak Sujir
2013-06-17 18:28 ` Benjamin Poirier [this message]
2013-06-17 18:56 ` Benjamin Poirier
2013-06-17 19:11 ` Michael Chan
2013-06-17 18:59 ` Michael Chan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130617182811.GA12442@d2.synalogic.ca \
--to=benjamin.poirier@gmail.com \
--cc=davem@davemloft.net \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=nsujir@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).