From: Guenter Roeck <linux@roeck-us.net>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Frank.Li@freescale.com, jim_baxter@mentor.com
Subject: Re: [PATCH] net: fec: Fix build for MCF5272
Date: Mon, 17 Jun 2013 21:03:12 -0700 [thread overview]
Message-ID: <20130618040312.GA12181@roeck-us.net> (raw)
In-Reply-To: <20130617.161151.1327615665309510068.davem@davemloft.net>
On Mon, Jun 17, 2013 at 04:11:51PM -0700, David Miller wrote:
> From: Guenter Roeck <linux@roeck-us.net>
> Date: Mon, 17 Jun 2013 13:16:19 -0700
>
> > Commits 4c09eed9 (net: fec: Enable imx6 enet checksum acceleration) and
> > baa70a5c (net: fec: enable pause frame to improve rx prefomance for 1G
> > network) introduced functionality into the FEC driver which is not
> > supported on MCF5272. As result, building images for MCF5272 fails,
> > complaining about several undefined symbols.
> >
> > Disabled the added functionality for MCF5272 builds.
> >
> > Cc: Frank Li <Frank.Li@freescale.com>
> > Cc: Jim Baxter <jim_baxter@mentor.com>
> > Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> > ---
> > Sorry for the added ifdefs. If anyone has a better idea on how to fix
> > the problems, let me know.
> >
> > This problem exists in 3.9 as well.
>
> Does the M5272 not have these registers, or have you simply not added
> defines for where there offsets are in that silicon instance?
>
> I'd much rather you add the register offset defines than pepper the
> entire driver with ifdefs.
>
I agree, and that would have been my preferred solution as well.
Unfortunately, according to the user manual (MCF5272 ColdFire
Integrated Microprocessor User's Manual), the registers do not exist
on this chip.
Guenter
next prev parent reply other threads:[~2013-06-18 4:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-17 20:16 [PATCH] net: fec: Fix build for MCF5272 Guenter Roeck
2013-06-17 23:11 ` David Miller
2013-06-18 4:03 ` Guenter Roeck [this message]
2013-06-18 7:19 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130618040312.GA12181@roeck-us.net \
--to=linux@roeck-us.net \
--cc=Frank.Li@freescale.com \
--cc=davem@davemloft.net \
--cc=jim_baxter@mentor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).