From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: aydin.arik@alliedtelesis.co.nz, kuznet@ms2.inr.ac.ru,
jmorris@namei.org, yoshfuji@linux-ipv6.org, kaber@trash.net,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] [PATCH v2] tcp: Fixed MD5 key lookups when adding/removing MD5.
Date: Wed, 19 Jun 2013 21:22:42 -0700 (PDT) [thread overview]
Message-ID: <20130619.212242.503302312923618047.davem@davemloft.net> (raw)
In-Reply-To: <1371214687.3252.130.camel@edumazet-glaptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Fri, 14 Jun 2013 05:58:07 -0700
> On Fri, 2013-06-14 at 23:30 +1200, Aydin Arik wrote:
>> MD5 key lookups on a given TCP socket were being performed
>> incorrectly. This fix alters parameter inputs to the MD5
>> lookup function tcp_md5_do_lookup, which is called by functions
>> tcp_md5_do_add and tcp_md5_do_del. Specifically, the change now
>> inputs the correct address and address family required to make
>> a proper lookup.
>>
>> Commit a915da9b69273815527ccb3789421cb7027b545b ("tcp: md5: rcu conversion")
>> is the source of the regression.
>>
>> Signed-off-by: Aydin Arik <aydin.arik@alliedtelesis.co.nz>
Applied, thanks.
prev parent reply other threads:[~2013-06-20 4:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-14 11:30 [PATCH 1/1] [PATCH v2] tcp: Fixed MD5 key lookups when adding/removing MD5 Aydin Arik
2013-06-14 12:58 ` Eric Dumazet
2013-06-20 4:22 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130619.212242.503302312923618047.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=aydin.arik@alliedtelesis.co.nz \
--cc=eric.dumazet@gmail.com \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox