From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org, therbert@google.com
Subject: Re: [PATCH net-next] htb: refactor struct htb_sched fields for performance
Date: Wed, 19 Jun 2013 23:07:42 -0700 (PDT) [thread overview]
Message-ID: <20130619.230742.1951790912113794085.davem@davemloft.net> (raw)
In-Reply-To: <1371292210.3252.159.camel@edumazet-glaptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Sat, 15 Jun 2013 03:30:10 -0700
> From: Eric Dumazet <edumazet@google.com>
>
> htb_sched structures are big, and source of false sharing on SMP.
>
> Every time a packet is queued or dequeue, many cache lines must be
> touched because structures are not lay out properly.
>
> By carefully splitting htb_sched in two parts, and define sub structures
> to increase data locality, we can improve performance dramatically on
> SMP.
>
> New htb_prio structure can also be used in htb_class to increase data
> locality.
>
> I got 26 % performance increase on a 24 threads machine, with 200
> concurrent netperf in TCP_RR mode, using a HTB hierarchy of 4 classes.
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Applied.
prev parent reply other threads:[~2013-06-20 6:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-15 10:30 [PATCH net-next] htb: refactor struct htb_sched fields for performance Eric Dumazet
2013-06-20 6:07 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130619.230742.1951790912113794085.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=therbert@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).