From: Michal Kubecek <mkubecek@suse.cz>
To: Veaceslav Falico <vfalico@redhat.com>
Cc: netdev@vger.kernel.org, fubar@us.ibm.com, andy@greyhouse.net,
davem@davemloft.net, linux@8192.net, nicolas.2p.debian@free.fr,
rick.jones2@hp.com, nikolay@redhat.com
Subject: Re: [PATCH v2 net-next 6/6] bonding: add an option to fail when any of arp_ip_target is inaccessible
Date: Fri, 21 Jun 2013 12:23:18 +0200 [thread overview]
Message-ID: <20130621102318.GA7269@unicorn.suse.cz> (raw)
In-Reply-To: <1371746105-2482-7-git-send-email-vfalico@redhat.com>
On Thu, Jun 20, 2013 at 06:35:05PM +0200, Veaceslav Falico wrote:
> @@ -1712,6 +1721,8 @@ int bond_enslave(struct net_device *bond_dev, struct net_device *slave_dev)
>
> new_slave->last_arp_rx = jiffies -
> (msecs_to_jiffies(bond->params.arp_interval) + 1);
> + for (i = 0; i < BOND_MAX_ARP_TARGETS; i++)
> + new_slave->target_last_arp_rx[i] = jiffies;
>
> if (bond->params.miimon && !bond->params.use_carrier) {
> link_reporting = bond_check_dev_link(bond, slave_dev, 1);
For cards with slow initial negotiation, this can cause a down -> up ->
down -> up flap on enslaving. This is why initial walue of last_arp_rx
was modified in commit f31c7937. Is there a reason not to initialize
target_last_arp_rx[i] to the same value?
Michal Kubecek
next prev parent reply other threads:[~2013-06-21 10:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-20 16:35 [PATCH v2 net-next 6/6] bonding: add an option to fail when any of arp_ip_target is inaccessible Veaceslav Falico
2013-06-20 17:28 ` Nikolay Aleksandrov
2013-06-20 18:16 ` Veaceslav Falico
2013-06-21 12:42 ` Veaceslav Falico
2013-06-21 10:23 ` Michal Kubecek [this message]
2013-06-21 11:00 ` Veaceslav Falico
2013-06-21 12:03 ` Michal Kubecek
2013-06-21 12:24 ` Veaceslav Falico
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130621102318.GA7269@unicorn.suse.cz \
--to=mkubecek@suse.cz \
--cc=andy@greyhouse.net \
--cc=davem@davemloft.net \
--cc=fubar@us.ibm.com \
--cc=linux@8192.net \
--cc=netdev@vger.kernel.org \
--cc=nicolas.2p.debian@free.fr \
--cc=nikolay@redhat.com \
--cc=rick.jones2@hp.com \
--cc=vfalico@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).