From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] [NET]: Unmap fragment page once iterator is done Date: Sun, 23 Jun 2013 18:36:44 -0700 (PDT) Message-ID: <20130623.183644.1085376304838914809.davem@davemloft.net> References: <1371257669-21115-1-git-send-email-wedsonaf@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: tgraf@suug.ch, netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: wedsonaf@gmail.com Return-path: In-Reply-To: <1371257669-21115-1-git-send-email-wedsonaf@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Wedson Almeida Filho Date: Fri, 14 Jun 2013 17:54:29 -0700 > Callers of skb_seq_read() are currently forced to call skb_abort_seq_read() > even when consuming all the data because the last call to skb_seq_read (the > one that returns 0 to indicate the end) fails to unmap the last fragment page. > > With this patch callers will be allowed to traverse the SKB data by calling > skb_prepare_seq_read() once and repeatedly calling skb_seq_read() as originally > intended (and documented in the original commit 677e90eda), that is, only call > skb_abort_seq_read() if the sequential read is actually aborted. > > Signed-off-by: Wedson Almeida Filho If you're going to do this I want you to get rid of the now-extraneous skb_abort_seq_read() calls at the same time. Thanks.