From: David Miller <davem@davemloft.net>
To: dlstevens@us.ibm.com
Cc: pshelar@nicira.com, dev@openvswitch.org, netdev@vger.kernel.org,
netdev-owner@vger.kernel.org
Subject: Re: [PATCH net-next 5/8] vxlan: Factor out vxlan send api.
Date: Sun, 23 Jun 2013 18:45:14 -0700 (PDT) [thread overview]
Message-ID: <20130623.184514.1432951068531783628.davem@davemloft.net> (raw)
In-Reply-To: <OF9BEEA27A.EA477839-ON87257B90.0045D6A5-85257B90.00463241@us.ibm.com>
From: David Stevens <dlstevens@us.ibm.com>
Date: Thu, 20 Jun 2013 08:46:42 -0400
>> From: Pravin B Shelar <pshelar@nicira.com>
>
>
>> @@ -1205,13 +1222,13 @@ static netdev_tx_t vxlan_xmit(struct sk_buff
>> *skb, struct net_device *dev)
>>
>> skb1 = skb_clone(skb, GFP_ATOMIC);
>> if (skb1) {
>> - rc1 = vxlan_xmit_one(skb1, dev, rdst, did_rsc);
>> + rc1 = __vxlan_xmit(skb1, dev, rdst, did_rsc);
>> if (rc == NETDEV_TX_OK)
>> rc = rc1;
>> }
>> }
>>
>> - rc1 = vxlan_xmit_one(skb, dev, rdst0, did_rsc);
>> + rc1 = __vxlan_xmit(skb, dev, rdst0, did_rsc);
>> if (rc == NETDEV_TX_OK)
>> rc = rc1;
>> return rc;
>
> You're changing the name of the function that sends a
> packet to one destination because you think "__vxlan_xmit"
> is more descriptive than "vxlan_xmit_one" ?
Agreed, this is rediculous.
prev parent reply other threads:[~2013-06-24 1:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-20 7:26 [PATCH net-next 5/8] vxlan: Factor out vxlan send api Pravin B Shelar
[not found] ` <1371713207-8232-1-git-send-email-pshelar-l0M0P4e3n4LQT0dZR+AlfA@public.gmane.org>
2013-06-20 12:46 ` David Stevens
2013-06-24 1:45 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130623.184514.1432951068531783628.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=dlstevens@us.ibm.com \
--cc=netdev-owner@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pshelar@nicira.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).