netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: sergei.shtylyov@cogentembedded.com
Cc: netdev@vger.kernel.org, nobuhiro.iwamatsu.yj@renesas.com,
	linux-sh@vger.kernel.org
Subject: Re: [PATCH 2/2] sh_eth: fix misreporting of transmit abort
Date: Mon, 24 Jun 2013 00:10:52 -0700 (PDT)	[thread overview]
Message-ID: <20130624.001052.717125614529984964.davem@davemloft.net> (raw)
In-Reply-To: <201306210113.43087.sergei.shtylyov@cogentembedded.com>

From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Date: Fri, 21 Jun 2013 01:13:42 +0400

> Due to obviously missing braces, EESR.TABT (transmit abort) interrupt may be
> reported even if it hasn't happened, just when EESR.TWB (transmit descriptor
> write-back) interrupt happens. Luckily (?), EESR.TWB is disabled by the driver
> via the TRIMD register and all the interrupt masks, so that transmit abort is
> never actually logged...
> 
> Put the braces where they should be and fix the incoherent comment, while at it. 
> 
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

Also applied to 'net'.

      reply	other threads:[~2013-06-24  7:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-20 21:13 [PATCH 2/2] sh_eth: fix misreporting of transmit abort Sergei Shtylyov
2013-06-24  7:10 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130624.001052.717125614529984964.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=linux-sh@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nobuhiro.iwamatsu.yj@renesas.com \
    --cc=sergei.shtylyov@cogentembedded.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).