From: Flavio Leitner <fbl@redhat.com>
To: netdev@vger.kernel.org, dborkman@redhat.com
Subject: Re: [PATCH net-next] ipv6: check return value of ipv6_get_lladdr
Date: Mon, 24 Jun 2013 15:22:21 -0300 [thread overview]
Message-ID: <20130624182220.GB22786@obelix.rh> (raw)
In-Reply-To: <20130623195648.GC13836@order.stressinduktion.org>
On Sun, Jun 23, 2013 at 09:56:48PM +0200, Hannes Frederic Sowa wrote:
> We should check the return value of ipv6_get_lladdr in inet6_set_iftoken.
>
> A possible situation, which could leave ll_addr unassigned is, when
> the user removed her link-local address but a global scoped address was
> already set. In this case the interface would still be IF_READY and not
> dead. In that case the RS source address is some value from the stack.
>
> Cc: Daniel Borkmann <dborkman@redhat.com>
> Signed-off-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
> ---
Reviewed-by: Flavio Leitner <fbl@redhat.com>
prev parent reply other threads:[~2013-06-24 18:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-23 19:56 [PATCH net-next] ipv6: check return value of ipv6_get_lladdr Hannes Frederic Sowa
2013-06-23 22:30 ` Hannes Frederic Sowa
2013-06-24 7:19 ` Daniel Borkmann
2013-06-24 18:22 ` Flavio Leitner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130624182220.GB22786@obelix.rh \
--to=fbl@redhat.com \
--cc=dborkman@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).