* [PATCH net-next] ipv6: don't disable interface if last ipv6 address is removed
@ 2013-06-23 22:22 Hannes Frederic Sowa
2013-06-25 23:24 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Hannes Frederic Sowa @ 2013-06-23 22:22 UTC (permalink / raw)
To: netdev; +Cc: yoshfuji
The reason behind this change is that as soon as we delete
the last ipv6 address of an interface we also lose the
/proc/sys/net/ipv6/conf/<interface> directory. This seems to be a
usability problem for me.
I don't see any reason why we should shutdown ipv6 on that interface in
such cases.
Cc: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Signed-off-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
---
net/ipv6/addrconf.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
index 8044912..3c1c789 100644
--- a/net/ipv6/addrconf.c
+++ b/net/ipv6/addrconf.c
@@ -2502,12 +2502,6 @@ static int inet6_addr_del(struct net *net, int ifindex, const struct in6_addr *p
read_unlock_bh(&idev->lock);
ipv6_del_addr(ifp);
-
- /* If the last address is deleted administratively,
- disable IPv6 on this interface.
- */
- if (list_empty(&idev->addr_list))
- addrconf_ifdown(idev->dev, 1);
return 0;
}
}
--
1.8.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] ipv6: don't disable interface if last ipv6 address is removed
2013-06-23 22:22 [PATCH net-next] ipv6: don't disable interface if last ipv6 address is removed Hannes Frederic Sowa
@ 2013-06-25 23:24 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2013-06-25 23:24 UTC (permalink / raw)
To: hannes; +Cc: netdev, yoshfuji
From: Hannes Frederic Sowa <hannes@stressinduktion.org>
Date: Mon, 24 Jun 2013 00:22:20 +0200
> The reason behind this change is that as soon as we delete
> the last ipv6 address of an interface we also lose the
> /proc/sys/net/ipv6/conf/<interface> directory. This seems to be a
> usability problem for me.
>
> I don't see any reason why we should shutdown ipv6 on that interface in
> such cases.
>
> Cc: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
> Signed-off-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-06-25 23:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-23 22:22 [PATCH net-next] ipv6: don't disable interface if last ipv6 address is removed Hannes Frederic Sowa
2013-06-25 23:24 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).