From: David Miller <davem@davemloft.net>
To: jasowang@redhat.com
Cc: mst@redhat.com, linux-kernel@vger.kernel.org,
edumazet@google.com, nhorman@tuxdriver.com,
netdev@vger.kernel.org, bhubbard@redhat.com
Subject: Re: [PATCH net] tun: fix recovery from gup errors
Date: Tue, 25 Jun 2013 16:24:29 -0700 (PDT) [thread overview]
Message-ID: <20130625.162429.966445706450575614.davem@davemloft.net> (raw)
In-Reply-To: <51C7BB8C.70304@redhat.com>
From: Jason Wang <jasowang@redhat.com>
Date: Mon, 24 Jun 2013 11:22:52 +0800
> On 06/23/2013 10:19 PM, Michael S. Tsirkin wrote:
>> get user pages might fail partially in tun zero copy
>> mode. To recover we need to put all pages that we got,
>> but code used a wrong index resulting in double-free
>> errors.
>>
>> Reported-by: Brad Hubbard <bhubbard@redhat.com>
>> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
>> ---
>>
>> I haven't figured out why do we get failures,
>> but recovery is clearly wrong.
>>
>> This is also -stable material.
>
> Acked-by: Jason Wang <jasowang@redhat.com>
Applied with the missing empty line added, I was tired of waiting for
Michael to take care of this himself.
next prev parent reply other threads:[~2013-06-25 23:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-23 14:19 [PATCH net] tun: fix recovery from gup errors Michael S. Tsirkin
2013-06-23 15:36 ` Sergei Shtylyov
2013-06-24 12:54 ` Michael S. Tsirkin
2013-06-24 18:34 ` David Miller
2013-06-24 3:22 ` Jason Wang
2013-06-25 23:24 ` David Miller [this message]
2013-06-24 11:31 ` Neil Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130625.162429.966445706450575614.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bhubbard@redhat.com \
--cc=edumazet@google.com \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).