From: David Miller <davem@davemloft.net>
To: stephen@networkplumber.org
Cc: sakiwit@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next 1/2] net: convert lists of macros to enumerations
Date: Tue, 25 Jun 2013 16:26:07 -0700 (PDT) [thread overview]
Message-ID: <20130625.162607.2024533380367124753.davem@davemloft.net> (raw)
In-Reply-To: <20130624081414.492ceeb0@nehalam.linuxnetplumber.net>
From: Stephen Hemminger <stephen@networkplumber.org>
Date: Mon, 24 Jun 2013 08:14:14 -0700
> On Sun, 23 Jun 2013 15:56:16 -0600
> Jean Sacren <sakiwit@gmail.com> wrote:
>
>> Use enumerations to replace macros for simpler preprocessing. Map numeric
>> values to enumerators. Where required, prepend the list with an additional
>> enumerator to accommodate the rest.
>>
>> Signed-off-by: Jean Sacren <sakiwit@gmail.com>
>
> Converting the network based header files is easy and safe as long
> as you test it. Not sure if it is worth the effort.
>
> But changing the uapi exported header risks breaking applications that
> were doing:
>
> #ifdef SIOCXXXX
> do some code to enable that
> #endif
>
> Since enum values don't show up in the CPP namespace.
Agreed, these patches aren't to be considered seriously. Too much
potential breakage, and even without that risk I see pretty much
zero value to these changes.
prev parent reply other threads:[~2013-06-25 23:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-23 21:56 [PATCH net-next 1/2] net: convert lists of macros to enumerations Jean Sacren
2013-06-23 21:56 ` [PATCH net-next 2/2] net: uapi: do not manually set the first enumerator to zero Jean Sacren
2013-06-24 15:14 ` [PATCH net-next 1/2] net: convert lists of macros to enumerations Stephen Hemminger
2013-06-25 23:26 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130625.162607.2024533380367124753.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=sakiwit@gmail.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).