Netdev List
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: yamahata@valinux.co.jp
Cc: eric.dumazet@gmail.com, netdev@vger.kernel.org,
	murphy.mccauley@gmail.com, pshelar@nicira.com, jesse@nicira.com,
	dev@openvswitch.org
Subject: Re: [PATCH] loopback: set pkt_type to PACKET_HOST explicitly
Date: Wed, 26 Jun 2013 15:29:30 -0700 (PDT)	[thread overview]
Message-ID: <20130626.152930.1401552744929449732.davem@davemloft.net> (raw)
In-Reply-To: <20130626093751.GB8524@valinux.co.jp>

From: Isaku Yamahata <yamahata@valinux.co.jp>
Date: Wed, 26 Jun 2013 18:37:51 +0900

> veth does. vethb-peer in the above example.
> (veth_xmit() -> dev_forward_skb() -> eth_type_trans())
> The destination mac address of arp reply is set to the one of
> vetha (!= vethb-peer). So vethb-peer sets pkt_type to OTHERHOST.
> bridge and gretap doesn't touch skb->pkt_type.

I think the dev_forward_skb() assignment of pkt_type should be done
after the call to eth_type_trans().

That's the whole point, we know we're looping the packet back to a
local device on this host.

I'm not applying this loopback patch, sorry.

  reply	other threads:[~2013-06-26 22:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-26  7:34 [PATCH] loopback: set pkt_type to PACKET_HOST explicitly Isaku Yamahata
2013-06-26  8:40 ` Eric Dumazet
2013-06-26  9:37   ` Isaku Yamahata
2013-06-26 22:29     ` David Miller [this message]
2013-06-27  5:29       ` Isaku Yamahata
2013-06-27  8:50         ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130626.152930.1401552744929449732.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=dev@openvswitch.org \
    --cc=eric.dumazet@gmail.com \
    --cc=jesse@nicira.com \
    --cc=murphy.mccauley@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=pshelar@nicira.com \
    --cc=yamahata@valinux.co.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox