From: David Miller <davem@davemloft.net>
To: nikolay@redhat.com
Cc: netdev@vger.kernel.org, andy@greyhouse.net, fubar@us.ibm.com
Subject: Re: [PATCH net-next 0/3] bonding: struct bonding cleanup and MAC set fixes
Date: Thu, 27 Jun 2013 22:51:16 -0700 (PDT) [thread overview]
Message-ID: <20130627.225116.236409010811785653.davem@davemloft.net> (raw)
In-Reply-To: <1372259619-32430-1-git-send-email-nikolay@redhat.com>
From: Nikolay Aleksandrov <nikolay@redhat.com>
Date: Wed, 26 Jun 2013 17:13:36 +0200
> This patchset removes some unnecessary struct bonding members. It also
> fixes MAC setting inconsistencies (i.e. if a bond's MAC is set after
> creation but prior to enslaving, it is lost and the first slave's MAC is
> cloned again). Before these patches the only way to keep a user-defined MAC
> is either to set it after enslaving or to create the bond with that MAC.
> Patch 01 - removes setup_by_slave member
> Patch 02 - removes dev_addr_from_first member and does the MAC fixing
> Patch 03 - introduces the use of NET_ADDR_STOLEN when a MAC is cloned
These cleanups seem pretty reasonabl, all applied.
And yes I agree that those 3 pr_debug()'s in bond_set_dev_addr() should
be condensed into just one. Feel free to send a patch which does that.
Thanks.
prev parent reply other threads:[~2013-06-28 5:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-26 15:13 [PATCH net-next 0/3] bonding: struct bonding cleanup and MAC set fixes Nikolay Aleksandrov
2013-06-26 15:13 ` [PATCH net-next 1/3] bonding: remove unnecessary setup_by_slave member Nikolay Aleksandrov
2013-06-26 15:13 ` [PATCH net-next 2/3] bonding: remove unnecessary dev_addr_from_first member Nikolay Aleksandrov
2013-06-26 15:13 ` [PATCH net-next 3/3] bonding: when cloning a MAC use NET_ADDR_STOLEN Nikolay Aleksandrov
2013-06-28 5:51 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130627.225116.236409010811785653.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andy@greyhouse.net \
--cc=fubar@us.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=nikolay@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).